Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-11 Thread Kevin Wheatley
I guess it depends if you think that it is better to align with defacto behaviour (and maybe clarify/correct the specifications) or follow the specs and have users grumble about not matching the behaviour of 'applications X, Y and Z', I'm pretty certain Photoshop won't easily change its behaviour.

Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-10 Thread Carl Eugen Hoyos
2018-12-10 17:55 GMT+01:00, Kevin Wheatley : > I came across a similar discussion here: > > https://github.com/OpenImageIO/oiio/pull/1412 So the solution is: We don't fix it because it is broken elsewhere? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-10 Thread Kevin Wheatley
I came across a similar discussion here: https://github.com/OpenImageIO/oiio/pull/1412 Kevin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-10 Thread Nicolas George
Moritz Barsnick (2018-12-10): > That was my interpretation. It's a density, if units != 0, otherwise > the aspect ratio. (Would a density not correspond to the SAR? I.e. not > make sense with square pixels?) I did not follow the beginning of the discussion, but just in case it can help and was not

Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-10 Thread Moritz Barsnick
On Mon, Dec 10, 2018 at 13:19:57 +0100, Carl Eugen Hoyos wrote: > > units (1 byte) Units for the X and Y densities. > > units = 0: no units, X and Y specify the pixel aspect ratio > > units = 1: X and Y are dots per inch > > units = 2: X and Y are dots per cm > > Xdensity (2 bytes)

Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-10 Thread Carl Eugen Hoyos
2018-12-10 9:29 GMT+01:00, Moritz Barsnick : > On Mon, Dec 10, 2018 at 02:54:54 +0100, Carl Eugen Hoyos wrote: >> I hope somebody can prove me wrong! > > Not sure, see below. > >> This would need a slightly more sophisticated update to the decoder. > > Because it is also presumed incorrect? > >>

Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-10 Thread Michael Niedermayer
On Mon, Dec 10, 2018 at 12:33:52PM +0100, Michael Niedermayer wrote: > On Mon, Dec 10, 2018 at 02:54:54AM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Reading the specification and Wikipedia, it appears to me that FFmpeg > > is writing wrong values as aspect ratio for jfif files. > > I hope some

Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-10 Thread Michael Niedermayer
On Mon, Dec 10, 2018 at 02:54:54AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Reading the specification and Wikipedia, it appears to me that FFmpeg > is writing wrong values as aspect ratio for jfif files. > I hope somebody can prove me wrong! > > This would need a slightly more sophisticated updat

Re: [FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-10 Thread Moritz Barsnick
On Mon, Dec 10, 2018 at 02:54:54 +0100, Carl Eugen Hoyos wrote: > I hope somebody can prove me wrong! Not sure, see below. > This would need a slightly more sophisticated update to the decoder. Because it is also presumed incorrect? > put_bits(p, 16, 0x0102); > put_bits(p, 8,

[FFmpeg-devel] [RFC]lavc/mjpegenc_common: Fix aspect ratio

2018-12-09 Thread Carl Eugen Hoyos
Hi! Reading the specification and Wikipedia, it appears to me that FFmpeg is writing wrong values as aspect ratio for jfif files. I hope somebody can prove me wrong! This would need a slightly more sophisticated update to the decoder. Please comment, Carl Eugen From 9c42114da17c20ef6d81d3989b552