Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-05-20 Thread Paul B Mahol
On 5/5/16, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> >> There is clearly overread if you ignore >> >> first two bytes. >> > >> > How can I reproduce the overread? >> >> By decoding file, looking at ffmpeg output. > > I did that and I don't see an overread: > What do I miss?

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-05-05 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > >> There is clearly overread if you ignore > >> first two bytes. > > > > How can I reproduce the overread? > > By decoding file, looking at ffmpeg output. I did that and I don't see an overread: What do I miss? Carl Eugen _

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-05-03 Thread Paul B Mahol
On 5/3/16, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> >> > So how should this be implemented? >> >> >> >> Perhaps predictor, if too big should be just clipped. >> > >> > Why do you think there is a too big predictor? >> > Two additional bytes are inserted at the beginning of >

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-05-03 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > >> > So how should this be implemented? > >> > >> Perhaps predictor, if too big should be just clipped. > > > > Why do you think there is a too big predictor? > > Two additional bytes are inserted at the beginning of > > every frame. > > Should the demuxer be pat

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-05-03 Thread Paul B Mahol
On 5/3/16, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> On 5/3/16, Carl Eugen Hoyos ag.or.at> wrote: >> > Paul B Mahol gmail.com> writes: >> > >> >> > I added the following comment locally: >> >> > // Levana Ovia Baby Monitor prepends each audio >> >> > frame with these two by

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-05-03 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > On 5/3/16, Carl Eugen Hoyos ag.or.at> wrote: > > Paul B Mahol gmail.com> writes: > > > >> > I added the following comment locally: > >> > // Levana Ovia Baby Monitor prepends each audio > >> > frame with these two bytes > >> > >> Sorry, life sucks. This patch

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-05-03 Thread Paul B Mahol
On 5/3/16, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> > I added the following comment locally: >> > // Levana Ovia Baby Monitor prepends each audio frame >> > with these two bytes >> >> Sorry, life sucks. This patch is unacceptable. > > So how should this be implemented? Perh

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-05-03 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > I added the following comment locally: > > // Levana Ovia Baby Monitor prepends each audio frame > > with these two bytes > > Sorry, life sucks. This patch is unacceptable. So how should this be implemented? Carl Eugen _

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-04-26 Thread Paul B Mahol
On 4/26/16, Carl Eugen Hoyos wrote: > Carl Eugen Hoyos ag.or.at> writes: > >> Attached patch fixes decoding a user-provided file here: >> https://dropfile.to/x7hQfJt > > I added the following comment locally: > // Levana Ovia Baby Monitor prepends each audio frame with these two bytes Sorry, lif

Re: [FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-04-26 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Attached patch fixes decoding a user-provided file here: > https://dropfile.to/x7hQfJt I added the following comment locally: // Levana Ovia Baby Monitor prepends each audio frame with these two bytes Carl Eugen _

[FFmpeg-devel] [RFC]lavc/adpcm: Support baby monitor adpcm_ms

2016-04-26 Thread Carl Eugen Hoyos
Hi! Attached patch fixes decoding a user-provided file here: https://dropfile.to/x7hQfJt I don't think there is a demuxer issue. Please comment, Carl Eugen diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 5d8aa41..5a11faa 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -840,