Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-29 Thread Carl Eugen Hoyos
Nicolas George nsup.org> writes: > Le septidi 7 brumaire, an CCXXIII, Carl Eugen Hoyos a écrit : > > The user should be told by libavformat if it does something > > unexpected. > > Related to ticket #4059. > > I do not object to this quick fix The warning was merged by Michael. Thank you, Car

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread wm4
On Tue, 28 Oct 2014 10:03:18 +0100 Carl Eugen Hoyos wrote: > On Tuesday 28 October 2014 09:57:12 am wm4 wrote: > > > > The user should be told by libavformat if it does something unexpected. > > > Related to ticket #4059. > > > > Why should it print a warning in this case, but not other cases wh

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread Clément Bœsch
On Tue, Oct 28, 2014 at 10:02:18AM +0100, Carl Eugen Hoyos wrote: > On Tuesday 28 October 2014 09:56:28 am Clément Bœsch wrote: > > > > +if (s && (r->type == FF_UTF16LE || r->type == FF_UTF16BE)) > > > +av_log(s, AV_LOG_WARNING, > > > + "UTF16 is automatically converted t

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXIII, Carl Eugen Hoyos a écrit : > I'd like to print a warning in that case as well, how can I > reproduce it? There is nothing to reproduce: text subtitles in Matroska are UTF-8, period. Regards, -- Nicolas George signature.asc Description: Digital signature _

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread Carl Eugen Hoyos
On Tuesday 28 October 2014 09:57:12 am wm4 wrote: > > The user should be told by libavformat if it does something unexpected. > > Related to ticket #4059. > > Why should it print a warning in this case, but not other cases when > the subtitle packets are already in UTF-8, such as Matroska? I'd li

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread Carl Eugen Hoyos
On Tuesday 28 October 2014 09:56:28 am Clément Bœsch wrote: > > +if (s && (r->type == FF_UTF16LE || r->type == FF_UTF16BE)) > > +av_log(s, AV_LOG_WARNING, > > + "UTF16 is automatically converted to UTF8, do not specify > > a character encoding\n"); > > av_log() accepts a

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread wm4
On Tue, 28 Oct 2014 09:58:48 +0100 Nicolas George wrote: > Le septidi 7 brumaire, an CCXXIII, Carl Eugen Hoyos a écrit : > > The user should be told by libavformat if it does something unexpected. > > Related to ticket #4059. > > I do not object to this quick fix, but the correct fix would be to

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXIII, Carl Eugen Hoyos a écrit : > The user should be told by libavformat if it does something unexpected. > Related to ticket #4059. I do not object to this quick fix, but the correct fix would be to set the codec context sub_charenc and sub_charenc_mode correctly in

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread wm4
On Tue, 28 Oct 2014 08:35:12 +0100 Carl Eugen Hoyos wrote: > Hi! > > The user should be told by libavformat if it does something unexpected. > Related to ticket #4059. > > Please comment, Carl Eugen Why should it print a warning in this case, but not other cases when the subtitle packets are a

Re: [FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread Clément Bœsch
On Tue, Oct 28, 2014 at 08:35:12AM +0100, Carl Eugen Hoyos wrote: > Hi! > > The user should be told by libavformat if it does something unexpected. > Related to ticket #4059. > > Please comment, Carl Eugen [...] > -void ff_text_init_avio(FFTextReader *r, AVIOContext *pb) > +void ff_text_init_avi

[FFmpeg-devel] [RFC]Print a warning if a subtitle demuxer changes utf16 to utf8.

2014-10-28 Thread Carl Eugen Hoyos
Hi! The user should be told by libavformat if it does something unexpected. Related to ticket #4059. Please comment, Carl Eugen diff --git a/libavformat/assdec.c b/libavformat/assdec.c index ccbf4c0..c62e76f 100644 --- a/libavformat/assdec.c +++ b/libavformat/assdec.c @@ -112,7 +112,7 @@ static i