Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 09:34:46PM +0100, wm4 wrote: > On Sun, 1 Mar 2015 20:34:57 +0100 > Michael Niedermayer wrote: > > > On Sun, Mar 01, 2015 at 07:57:56PM +0100, wm4 wrote: > > > On Sun, 1 Mar 2015 19:48:20 +0100 > > > Nicolas George wrote: > > > > > > > Le primidi 11 ventôse, an CCXXIII, w

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread wm4
On Sun, 1 Mar 2015 20:34:57 +0100 Michael Niedermayer wrote: > On Sun, Mar 01, 2015 at 07:57:56PM +0100, wm4 wrote: > > On Sun, 1 Mar 2015 19:48:20 +0100 > > Nicolas George wrote: > > > > > Le primidi 11 ventôse, an CCXXIII, wm4 a écrit : > > > > I prefer the color of fuck broken platforms nobo

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 07:57:56PM +0100, wm4 wrote: > On Sun, 1 Mar 2015 19:48:20 +0100 > Nicolas George wrote: > > > Le primidi 11 ventôse, an CCXXIII, wm4 a écrit : > > > I prefer the color of fuck broken platforms nobody uses. > > > > Well, obviously someone uses a platform where it makes a

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread wm4
On Sun, 1 Mar 2015 19:48:20 +0100 Nicolas George wrote: > Le primidi 11 ventôse, an CCXXIII, wm4 a écrit : > > I prefer the color of fuck broken platforms nobody uses. > > Well, obviously someone uses a platform where it makes a difference, > otherwise nobody would have noticed. > > Regards, >

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Nicolas George
Le primidi 11 ventôse, an CCXXIII, wm4 a écrit : > I prefer the color of fuck broken platforms nobody uses. Well, obviously someone uses a platform where it makes a difference, otherwise nobody would have noticed. Regards, -- Nicolas George signature.asc Description: Digital signature _

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread wm4
On Sun, 1 Mar 2015 16:26:20 +0100 Michael Niedermayer wrote: > On Sun, Mar 01, 2015 at 01:11:08PM +0100, wm4 wrote: > > On Sun, 1 Mar 2015 12:09:28 +0100 > > Carl Eugen Hoyos wrote: > > > > > On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > > > > On Sun, Mar 01, 2015 at 09:44:30

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 01:11:08PM +0100, wm4 wrote: > On Sun, 1 Mar 2015 12:09:28 +0100 > Carl Eugen Hoyos wrote: > > > On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > > > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > > > > Attached untested patch should fi

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread wm4
On Sun, 1 Mar 2015 12:09:28 +0100 Carl Eugen Hoyos wrote: > On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > > > Attached untested patch should fix compilation on broken platforms. > > > We don't use round() cur

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 12:09:28PM +0100, Carl Eugen Hoyos wrote: > On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > > > Attached untested patch should fix compilation on broken platforms. > > > We don't use round

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Carl Eugen Hoyos
On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > > Attached untested patch should fix compilation on broken platforms. > > We don't use round() currently because it appears less portable than > > lrintf(). > yes re

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > Attached untested patch should fix compilation on > > broken platforms. We don't use round() currently > > because it appears less portable than lrintf(). > > which platform is that ? http://fate.ffmpeg.org/history.cgi?slot=x86-opensolaris-suncc5.10 Loo

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached untested patch should fix compilation on broken platforms. > We don't use round() currently because it appears less portable than > lrintf(). which platform is that ? but yes reducing float code usage should be

[FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Carl Eugen Hoyos
Hi! Attached untested patch should fix compilation on broken platforms. We don't use round() currently because it appears less portable than lrintf(). Please comment, Carl Eugen diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 9fd8eef..2826f36 100644 --- a/libavcodec/pngenc.c +++ b/l