Re: [FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-02 Thread Michael Niedermayer
On Mon, Jul 01, 2024 at 03:39:23PM +0200, Michael Niedermayer wrote: latest coverity fun: CID 1604534: (#1 of 1): Overflowed constant (INTEGER_OVERFLOW) overflow_const: Expression gain, which is equal to 4294967295, where get_bits1(gb) ? get_bits(gb, 4) - 7U : 4294967295U is known to be equal t

Re: [FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-02 Thread Michael Niedermayer
On Tue, Jul 02, 2024 at 06:51:16AM +0200, Vittorio Giovara wrote: > On Mon, Jul 1, 2024 at 11:00 PM Michael Niedermayer > wrote: > > > On Mon, Jul 01, 2024 at 10:19:31PM +0200, Michael Niedermayer wrote: > > > On Mon, Jul 01, 2024 at 08:50:24PM +0200, Timo Rothenpieler wrote: > > > > On 01.07.202

Re: [FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-02 Thread Timo Rothenpieler
On 01/07/2024 22:19, Michael Niedermayer wrote: On Mon, Jul 01, 2024 at 08:50:24PM +0200, Timo Rothenpieler wrote: On 01.07.2024 15:39, Michael Niedermayer wrote: Hi all coverity seems to have started to do a new thing. Namely if theres a return statement it assumes it can independant of every

Re: [FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-01 Thread Vittorio Giovara
On Mon, Jul 1, 2024 at 11:00 PM Michael Niedermayer wrote: > On Mon, Jul 01, 2024 at 10:19:31PM +0200, Michael Niedermayer wrote: > > On Mon, Jul 01, 2024 at 08:50:24PM +0200, Timo Rothenpieler wrote: > > > On 01.07.2024 15:39, Michael Niedermayer wrote: > > > > Hi all > > > > > > > > coverity se

Re: [FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-01 Thread Michael Niedermayer
On Mon, Jul 01, 2024 at 10:19:31PM +0200, Michael Niedermayer wrote: > On Mon, Jul 01, 2024 at 08:50:24PM +0200, Timo Rothenpieler wrote: > > On 01.07.2024 15:39, Michael Niedermayer wrote: > > > Hi all > > > > > > coverity seems to have started to do a new thing. Namely if theres a > > > return s

Re: [FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-01 Thread Michael Niedermayer
On Mon, Jul 01, 2024 at 08:50:24PM +0200, Timo Rothenpieler wrote: > On 01.07.2024 15:39, Michael Niedermayer wrote: > > Hi all > > > > coverity seems to have started to do a new thing. Namely if theres a > > return statement it assumes it can independant of everything occurr > > > > an example w

Re: [FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-01 Thread Timo Rothenpieler
On 01.07.2024 15:39, Michael Niedermayer wrote: Hi all coverity seems to have started to do a new thing. Namely if theres a return statement it assumes it can independant of everything occurr an example would be av_rescale() which on overflow returns INT64_MIN also with the right flags av_resc

Re: [FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-01 Thread Michael Niedermayer
On Mon, Jul 01, 2024 at 03:39:23PM +0200, Michael Niedermayer wrote: > Hi all > > coverity seems to have started to do a new thing. Namely if theres a > return statement it assumes it can independant of everything occurr > > an example would be av_rescale() which on overflow returns INT64_MIN >

[FFmpeg-devel] [RFC] av_rescale() coverity

2024-07-01 Thread Michael Niedermayer
Hi all coverity seems to have started to do a new thing. Namely if theres a return statement it assumes it can independant of everything occurr an example would be av_rescale() which on overflow returns INT64_MIN also with the right flags av_rescale() will pass INT64_MIN and INT64_MAX through fr