On Mon, Jun 19, 2017 at 14:32:38 +0200, Hein-Pieter van Braam wrote:
> > > +if (! opcode) {
> >
> > Style: You should drop the space.
>
> You mean the space between the ! and opcode? The space between if and
> opening parenthesis should stay, right?
Correct. The handling of paranthes
I've resubmitted the patch in a more reviewable format here:
http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/212532.html
having said that:
On Mon, 2017-06-19 at 14:22 +0200, Moritz Barsnick wrote:
> On Sat, Jun 17, 2017 at 19:13:52 +0200, Hein-Pieter van Braam wrote:
> > +s->pixel_
On Sat, Jun 17, 2017 at 19:13:52 +0200, Hein-Pieter van Braam wrote:
> +s->pixel_ptr = frame->data[0] + x + y*frame->linesize[0];
Style: You might want to add spaces around '*'.
> +if (! opcode) {
Style: You should drop the space.
> +if (opcode < 0) {
> +
On Sat, 2017-06-17 at 18:45 +0200, Paul B Mahol wrote:
> Have you made sure that new code does not cause overreads?
>
> Use bytestream2* for that.
>
I have made that change, thanks, the code actually looks better now
too!
Attached is a new version of the patch.
Thanks!
- HPFrom e8a45ce4748e39
On 6/17/17, Hein-Pieter van Braam wrote:
> Hi all,
>
> I seemed to have done something wrong when fixing the patchcheck
> problems originally. Apparently I didn't build between making my
> 'fixes' and creating the patch. The previous patch doesn't compile.
>
> I fixed this in this version, my apol
Hi all,
I seemed to have done something wrong when fixing the patchcheck
problems originally. Apparently I didn't build between making my
'fixes' and creating the patch. The previous patch doesn't compile.
I fixed this in this version, my apologies for the noise.
I've also fixed reading garbage
Hi all,
This patch implements support for 3 previously unknown Interplay MVE
opcodes. These opcodes together implement support for 2 additional
video frame formats.
This is my first time trying to contribute to ffmpeg so I expect this
code to not be entirely up to snuff, I'm interested in getting
