Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-05-08 Thread Philip Langdale
On Thu, 27 Apr 2017 01:12:55 +0200 Timo Rothenpieler wrote: > > This seems to be a regression introduced when filtergraph > > initialization related changes were passed. The below commit and > > its follow up seems to have caused the issue. I am looking to fix > > this. Please let us know if you

Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-04-26 Thread Timo Rothenpieler
This seems to be a regression introduced when filtergraph initialization related changes were passed. The below commit and its follow up seems to have caused the issue. I am looking to fix this. Please let us know if you have any suggestions in mind. Thanks https://github.com/FFmpeg/FFmpeg/comm

Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-04-26 Thread Ganapathy Raman Kasi
ler Sent: Wednesday, April 26, 2017 1:43 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction > Thanks, patch looks fine to me now. > While testing, I came across some very weird behavior: > > The following commandline: > ./ffmpeg -

Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-04-26 Thread Timo Rothenpieler
Thanks, patch looks fine to me now. While testing, I came across some very weird behavior: The following commandline: ./ffmpeg -hwaccel cuvid -c:v h264_cuvid -i test.mkv -an -sn -c:v h264_nvenc -preset slow -qp 22 -bf 0 -f null - Sometimes, it runs into the following error: [h264_nvenc @ 0x3f7d

Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-04-26 Thread Timo Rothenpieler
> With this new -bf related issue, I'm not so sure about that anymore though, > and I'm wondering if something in ffmpeg corrupts memory somewhere, somehow, > when -bf is set. Just wanted to let it running in a loop for a while, and apparently adding -t 5, 10, 30, or basically any value of time

Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-04-26 Thread Timo Rothenpieler
Thanks, patch looks fine to me now. While testing, I came across some very weird behavior: The following commandline: ./ffmpeg -hwaccel cuvid -c:v h264_cuvid -i test.mkv -an -sn -c:v h264_nvenc -preset slow -qp 22 -bf 0 -f null - Sometimes, it runs into the following error: [h264_nvenc @ 0x3f7d8

Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-04-25 Thread Ben Chang
Hi Timo, Thanks for the review. Attaching patch updated with your suggestions and answering some queries from previous email. >Did you test if and how much it affects performance to reduce the default >delay from 32 to 4? >This was originally done because nvenc is extremely slow if you try to

Re: [FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-04-25 Thread Timo Rothenpieler
> From f3917a452c3e0636c27876e84a4e3b57bb78dae5 Mon Sep 17 00:00:00 2001 > From: Ben Chang > Date: Wed, 19 Apr 2017 13:07:31 -0700 > Subject: [PATCH] NVENC surface allocation reduction > > This patch aims to reduce the number of input/output surfaces > NVENC allocates per session. Previous defaul

[FFmpeg-devel] [PATCH] NVENC Surface Allocation Reduction

2017-04-24 Thread Ben Chang
[sorry for re-sending; but still looking for review. Thanks!] Hi, This patch aims to reduce the number of input/output surfaces NVENC allocates per session. Previous default sets allocated surfaces to 32 (unless there is user specified param or lookahead involved). Having large number of sur

[FFmpeg-devel] [Patch] NVENC Surface Allocation Reduction

2017-04-19 Thread Ben Chang
Hi, This patch aims to reduce the number of input/output surfaces NVENC allocates per session. Previous default sets allocated surfaces to 32 (unless there is user specified param or lookahead involved). Having large number of surfaces consumes extra video memory (esp for higher resolution enco