Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr

2024-05-31 Thread Rémi Denis-Courmont
Le perjantaina 31. toukokuuta 2024, 22.28.03 EEST Lynne via ffmpeg-devel a écrit : > > Frankly, this test has outlived its usefulness for my purposes and I have > > had enough rebasing it again and again and again and again and again due > > to mostly external problems. As far as I am concerned,

Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr

2024-05-31 Thread James Almer
On 5/31/2024 2:51 PM, Rémi Denis-Courmont wrote: --- tests/checkasm/lpc.c | 57 ++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..62232fdaf7 100644 --- a/tests/checkasm/lpc.c

Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr

2024-05-31 Thread Lynne via ffmpeg-devel
On 31/05/2024 20:29, Rémi Denis-Courmont wrote: Le perjantaina 31. toukokuuta 2024, 21.23.43 EEST Lynne via ffmpeg-devel a écrit : Please don't randomize the length in tests. Pick a few lengths to check all corner cases. Checkasm tests should be deterministic in how long it takes to run them bet

Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr

2024-05-31 Thread Rémi Denis-Courmont
Le perjantaina 31. toukokuuta 2024, 21.23.43 EEST Lynne via ffmpeg-devel a écrit : > Please don't randomize the length in tests. Pick a few lengths to check > all corner cases. > Checkasm tests should be deterministic in how long it takes to run them > between invocations. I agree, but that pro

Re: [FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr

2024-05-31 Thread Lynne via ffmpeg-devel
On 31/05/2024 19:51, Rémi Denis-Courmont wrote: --- tests/checkasm/lpc.c | 57 ++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..62232fdaf7 100644 --- a/tests/checkasm/lpc.c

[FFmpeg-devel] [PATCHv6] checkasm/lpc: test compute_autocorr

2024-05-31 Thread Rémi Denis-Courmont
--- tests/checkasm/lpc.c | 57 ++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..62232fdaf7 100644 --- a/tests/checkasm/lpc.c +++ b/tests/checkasm/lpc.c @@ -16,6 +16,7 @@ * 51