Re: [FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

2019-06-09 Thread Reimar Döffinger
On 09.06.2019, at 03:07, Peter Ross wrote: > On Sat, Jun 08, 2019 at 08:49:15AM +0200, Reimar Döffinger wrote: >> >> >> On 08.06.2019, at 03:08, Peter Ross wrote: >> >>> --- >>> comments against v4 patch addressed. thanks. >>> >>> +#if CONFIG_VP4_DECODER >>> +static int vp4_get_mb_count(Vp3D

Re: [FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

2019-06-08 Thread Peter Ross
On Sat, Jun 08, 2019 at 08:49:15AM +0200, Reimar Döffinger wrote: > > > On 08.06.2019, at 03:08, Peter Ross wrote: > > > --- > > comments against v4 patch addressed. thanks. > > > > +#if CONFIG_VP4_DECODER > > +static int vp4_get_mb_count(Vp3DecodeContext *s, GetBitContext *gb) > > +{ > > +

Re: [FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

2019-06-07 Thread Reimar Döffinger
On 08.06.2019, at 03:08, Peter Ross wrote: > --- > comments against v4 patch addressed. thanks. > > +#if CONFIG_VP4_DECODER > +static int vp4_get_mb_count(Vp3DecodeContext *s, GetBitContext *gb) > +{ > +int v = 1; > +int bits; > +while ((bits = show_bits(gb, 9)) == 0x1ff && v < >

[FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

2019-06-07 Thread Peter Ross
--- comments against v4 patch addressed. thanks. Changelog |1 + configure |1 + doc/general.texi|2 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h|1 + libavcodec/codec_desc.c |7 + libavcodec/vp3.c| 728 +