Re: [FFmpeg-devel] [PATCHv4 1/4] lavc/h263dsp: add DCT dequantisation functions

2024-06-12 Thread James Almer
On 6/10/2024 5:23 PM, Rémi Denis-Courmont wrote: Note that optimised implementations of these functions will be taken into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra} are *not* overloaded by existing optimisations. --- libavcodec/h263dsp.c | 25 +

Re: [FFmpeg-devel] [PATCHv4 1/4] lavc/h263dsp: add DCT dequantisation functions

2024-06-11 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le tiistaina 11. kesäkuuta 2024, 13.30.28 EEST Andreas Rheinhardt a écrit : >>> +static void h263_dct_unquantize_intra_c(int16_t *block, size_t nCoeffs, >>> +int qmul, int qadd) >>> +{ >>> +if (nCoeffs > 0) >> >> Great, a branch. >

Re: [FFmpeg-devel] [PATCHv4 1/4] lavc/h263dsp: add DCT dequantisation functions

2024-06-11 Thread Rémi Denis-Courmont
Le tiistaina 11. kesäkuuta 2024, 13.30.28 EEST Andreas Rheinhardt a écrit : > > +static void h263_dct_unquantize_intra_c(int16_t *block, size_t nCoeffs, > > +int qmul, int qadd) > > +{ > > +if (nCoeffs > 0) > > Great, a branch. Okay so you want sarcasms

Re: [FFmpeg-devel] [PATCHv4 1/4] lavc/h263dsp: add DCT dequantisation functions

2024-06-11 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Note that optimised implementations of these functions will be taken > into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra} > are *not* overloaded by existing optimisations. > --- > libavcodec/h263dsp.c | 25 + > libavcodec/h263dsp

[FFmpeg-devel] [PATCHv4 1/4] lavc/h263dsp: add DCT dequantisation functions

2024-06-10 Thread Rémi Denis-Courmont
Note that optimised implementations of these functions will be taken into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra} are *not* overloaded by existing optimisations. --- libavcodec/h263dsp.c | 25 + libavcodec/h263dsp.h | 4 2 files changed, 29