Re: [FFmpeg-devel] [PATCHv4] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-10 Thread Michael Niedermayer
On Tue, Jul 09, 2024 at 05:41:32PM -0400, Sean McGovern wrote: > For even small values of 'asrc[x]', shifting them by 24 bits or more > will cause arithmetic overflow and be caught by > GCC's undefined behaviour sanitizer. > > Ensure the values do not overflow by up-casting the bracketed > express

[FFmpeg-devel] [PATCHv4] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-09 Thread Sean McGovern
For even small values of 'asrc[x]', shifting them by 24 bits or more will cause arithmetic overflow and be caught by GCC's undefined behaviour sanitizer. Ensure the values do not overflow by up-casting the bracketed expressions involving 'asrc' to uint32_t. --- libswscale/yuv2rgb.c | 4 ++-- 1 fi