Josh de Kock itanimul.li> writes:
> On Thu, Jul 7, 2016, at 10:47 AM, Carl Eugen Hoyos wrote:
> > Josh de Kock itanimul.li> writes:
> >
> > > +ret = openmpt_could_open_propability(
> >
> > I don't know anything about openmpt but what was
> > wrong with the original probe function sent by
On 06/30/2016 02:49 AM, Josh de Kock wrote:
Fixes ticket #5623
TODO: bump lavf minor
---
I looked more thoroughly at your patch again.
I'm commenting from libopenmpt perspective of course.
+openmpt->module = openmpt_module_create_from_memory(buf, size,
openmpt_logfunc, s, NULL);
+
On 07/08/2016 10:17 PM, Nicolas George wrote:
Le primidi 21 messidor, an CCXXIV, Jörn Heusipp a écrit :
Regarding AVProbeData:
Looking at AVProbeData, I can see no (optional) field describing the file
size:
typedef struct AVProbeData {
const char *filename;
unsigned char *buf; /**<
[ Trimming people I know are on the list from the Cc. ]
Le primidi 21 messidor, an CCXXIV, Jörn Heusipp a écrit :
> (I am one of the libopenmpt maintainers)
> We have been following the ffmpeg libopenmpt demuxer patches and we already
> gave feedback at https://bugs.openmpt.org/view.php?id=817 (fo
Hello!
On 06/30/2016 02:49 AM, Josh de Kock wrote:
Fixes ticket #5623
TODO: bump lavf minor
(I am one of the libopenmpt maintainers)
We have been following the ffmpeg libopenmpt demuxer patches and we
already gave feedback at https://bugs.openmpt.org/view.php?id=817 (for
reference).
I'm
Le tridi 13 messidor, an CCXXIV, Josh de Kock a écrit :
> +static int probe_openmpt(AVProbeData *p)
> +{
> +double ret;
> +FILE *file;
> +
> +if(!p->filename)
> +return 0;
> +
> +file = fopen(p->filename, "rb");
> +if (!file)
> +return AVERROR(errno);
> +
> +
On Thu, Jul 07, 2016 at 03:13:53PM +0100, Josh de Kock wrote:
> Hi,
>
> On Thu, Jul 7, 2016, at 10:47 AM, Carl Eugen Hoyos wrote:
> > Josh de Kock itanimul.li> writes:
> >
> > > +ret = openmpt_could_open_propability(
> >
> > I don't know anything about openmpt but what was
> > wrong with t
Hi,
On Thu, Jul 7, 2016, at 10:47 AM, Carl Eugen Hoyos wrote:
> Josh de Kock itanimul.li> writes:
>
> > +ret = openmpt_could_open_propability(
>
> I don't know anything about openmpt but what was
> wrong with the original probe function sent by you?
It probed one format, and not very well,
Josh de Kock itanimul.li> writes:
> +ret = openmpt_could_open_propability(
I don't know anything about openmpt but what was
wrong with the original probe function sent by you?
Iiuc, this code would slow down probing everything or
am I missing something?
Thank you, Carl Eugen
___
Fixes ticket #5623
TODO: bump lavf minor
---
Changelog| 1 +
configure| 4 +
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/libopenmpt.c | 200 +++
5 files changed, 207 insertions(+)
10 matches
Mail list logo
