Re: [FFmpeg-devel] [PATCHv2] ffserver: fix incorrect strlcpy usage

2015-11-09 Thread Ganesh Ajjanagadde
On Mon, Nov 9, 2015 at 6:50 PM, Michael Niedermayer wrote: > On Sat, Nov 07, 2015 at 07:21:59AM -0500, Ganesh Ajjanagadde wrote: >> Somewhat ironic that this "safe" interface is actually being used >> unsafely here. This fixes the usage preventing potential null pointer >> dereference, where the o

Re: [FFmpeg-devel] [PATCHv2] ffserver: fix incorrect strlcpy usage

2015-11-09 Thread Michael Niedermayer
On Sat, Nov 07, 2015 at 07:21:59AM -0500, Ganesh Ajjanagadde wrote: > Somewhat ironic that this "safe" interface is actually being used > unsafely here. This fixes the usage preventing potential null pointer > dereference, where the old code was doubly broken: ctime can return > NULL, and ctime can

[FFmpeg-devel] [PATCHv2] ffserver: fix incorrect strlcpy usage

2015-11-07 Thread Ganesh Ajjanagadde
Somewhat ironic that this "safe" interface is actually being used unsafely here. This fixes the usage preventing potential null pointer dereference, where the old code was doubly broken: ctime can return NULL, and ctime can return an arbitrarily long buffer. Signed-off-by: Ganesh Ajjanagadde ---