Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 09:12:02AM -0400, Ganesh Ajjanagadde wrote: > On Mon, Oct 12, 2015 at 8:56 AM, wm4 wrote: > > On Mon, 12 Oct 2015 08:39:53 -0400 > > Ganesh Ajjanagadde wrote: > > > >> On Mon, Oct 12, 2015 at 8:24 AM, wm4 wrote: > >> > On Mon, 12 Oct 2015 08:14:14 -0400 > >> > Ganesh Ajja

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 9:15 AM, wm4 wrote: > On Mon, 12 Oct 2015 09:12:02 -0400 > Ganesh Ajjanagadde wrote: > >> On Mon, Oct 12, 2015 at 8:56 AM, wm4 wrote: >> > On Mon, 12 Oct 2015 08:39:53 -0400 >> > Ganesh Ajjanagadde wrote: >> > >> >> On Mon, Oct 12, 2015 at 8:24 AM, wm4 wrote: >> >> > On

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread wm4
On Mon, 12 Oct 2015 09:12:02 -0400 Ganesh Ajjanagadde wrote: > On Mon, Oct 12, 2015 at 8:56 AM, wm4 wrote: > > On Mon, 12 Oct 2015 08:39:53 -0400 > > Ganesh Ajjanagadde wrote: > > > >> On Mon, Oct 12, 2015 at 8:24 AM, wm4 wrote: > >> > On Mon, 12 Oct 2015 08:14:14 -0400 > >> > Ganesh Ajjanagad

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 8:56 AM, wm4 wrote: > On Mon, 12 Oct 2015 08:39:53 -0400 > Ganesh Ajjanagadde wrote: > >> On Mon, Oct 12, 2015 at 8:24 AM, wm4 wrote: >> > On Mon, 12 Oct 2015 08:14:14 -0400 >> > Ganesh Ajjanagadde wrote: >> > >> >> On Mon, Oct 12, 2015 at 8:03 AM, Michael Niedermayer >>

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread wm4
On Mon, 12 Oct 2015 08:39:53 -0400 Ganesh Ajjanagadde wrote: > On Mon, Oct 12, 2015 at 8:24 AM, wm4 wrote: > > On Mon, 12 Oct 2015 08:14:14 -0400 > > Ganesh Ajjanagadde wrote: > > > >> On Mon, Oct 12, 2015 at 8:03 AM, Michael Niedermayer > >> wrote: > >> > On Mon, Oct 12, 2015 at 01:46:19PM +0

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 8:24 AM, wm4 wrote: > On Mon, 12 Oct 2015 08:14:14 -0400 > Ganesh Ajjanagadde wrote: > >> On Mon, Oct 12, 2015 at 8:03 AM, Michael Niedermayer >> wrote: >> > On Mon, Oct 12, 2015 at 01:46:19PM +0200, Michael Niedermayer wrote: >> >> On Fri, Jul 31, 2015 at 01:48:18PM +020

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread wm4
On Mon, 12 Oct 2015 08:14:14 -0400 Ganesh Ajjanagadde wrote: > On Mon, Oct 12, 2015 at 8:03 AM, Michael Niedermayer > wrote: > > On Mon, Oct 12, 2015 at 01:46:19PM +0200, Michael Niedermayer wrote: > >> On Fri, Jul 31, 2015 at 01:48:18PM +0200, Nicolas George wrote: > >> [...] > >> >-> "ttyc

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 08:03:03AM -0400, Ganesh Ajjanagadde wrote: > On Mon, Oct 12, 2015 at 7:46 AM, Michael Niedermayer > wrote: > > On Fri, Jul 31, 2015 at 01:48:18PM +0200, Nicolas George wrote: > > [...] > >>-> "ttyctl -f" in ~/.zshrc, "bash_tty_mode=$(stty -g); > >>PROMPT_COMMAND='s

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 8:03 AM, Michael Niedermayer wrote: > On Mon, Oct 12, 2015 at 01:46:19PM +0200, Michael Niedermayer wrote: >> On Fri, Jul 31, 2015 at 01:48:18PM +0200, Nicolas George wrote: >> [...] >> >-> "ttyctl -f" in ~/.zshrc, "bash_tty_mode=$(stty -g); >> >PROMPT_COMMAND='stty

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 01:46:19PM +0200, Michael Niedermayer wrote: > On Fri, Jul 31, 2015 at 01:48:18PM +0200, Nicolas George wrote: > [...] > >-> "ttyctl -f" in ~/.zshrc, "bash_tty_mode=$(stty -g); > >PROMPT_COMMAND='stty $bash_tty_mode'" in ~/.bashrc; that can be added in > >the FAQ

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 7:46 AM, Michael Niedermayer wrote: > On Fri, Jul 31, 2015 at 01:48:18PM +0200, Nicolas George wrote: > [...] >>-> "ttyctl -f" in ~/.zshrc, "bash_tty_mode=$(stty -g); >>PROMPT_COMMAND='stty $bash_tty_mode'" in ~/.bashrc; that can be added in >>the FAQ or the wik

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-10-12 Thread Michael Niedermayer
On Fri, Jul 31, 2015 at 01:48:18PM +0200, Nicolas George wrote: [...] >-> "ttyctl -f" in ~/.zshrc, "bash_tty_mode=$(stty -g); >PROMPT_COMMAND='stty $bash_tty_mode'" in ~/.bashrc; that can be added in >the FAQ or the wiki. the patch was applied and this does not work the first segfaul

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Ganesh Ajjanagadde
On Fri, Jul 31, 2015 at 9:06 AM, Nicolas George wrote: > Le tridi 13 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >> Thanks for disentangling the separate issues very neatly >> with a mathematical precision. > > And thank you for turning them into patches. They are exactly what I had in > m

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Nicolas George
Le tridi 13 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit : > Thanks for disentangling the separate issues very neatly > with a mathematical precision. And thank you for turning them into patches. They are exactly what I had in mind (I probably would have added a snide remark against packagers

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Ganesh Ajjanagadde
On Fri, Jul 31, 2015 at 7:48 AM, Nicolas George wrote: > Le tridi 13 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >> Nevertheless, echo $? invoked right after this yields 2 for both. >> The reason this happens is the md5sum wrapper sees that the output >> file has not been written, >> and e

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Nicolas George
Le tridi 13 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit : > Nevertheless, echo $? invoked right after this yields 2 for both. > The reason this happens is the md5sum wrapper sees that the output > file has not been written, > and errors out there (see the .err files for precisely what I mean)

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Ganesh Ajjanagadde
On Fri, Jul 31, 2015 at 4:32 AM, Nicolas George wrote: > Le duodi 12 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >> ffmpeg(){ >> +stty_opts="$(stty --save)" >> dec_opts="-hwaccel $hwaccel -threads $threads -thread_type $thread_type" >> ffmpeg_args="-nostats -cpuflags $cpufla

Re: [FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Nicolas George
Le duodi 12 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit : > ffmpeg(){ > +stty_opts="$(stty --save)" > dec_opts="-hwaccel $hwaccel -threads $threads -thread_type $thread_type" > ffmpeg_args="-nostats -cpuflags $cpuflags" > for arg in $@; do > @@ -99,6 +100,7 @@ ffmpeg(){ >

[FFmpeg-devel] [PATCHv2] ffmpeg: modify tty state when stderr is redirected

2015-07-30 Thread Ganesh Ajjanagadde
This fixes Ticket2964 Signed-off-by: Ganesh Ajjanagadde --- ffmpeg.c | 2 +- tests/fate-run.sh | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 5575e2f..eb3f613 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -372,7 +372,7 @@ void term_init(void)