Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

2024-01-02 Thread Nuo Mi
On Tue, Jan 2, 2024 at 11:57 PM Lynne wrote: > Jan 2, 2024, 14:22 by nuomi2...@gmail.com: > > > On Mon, Jan 1, 2024 at 11:13 PM Lynne wrote: > > > >> > >> > >> > >> Jan 1, 2024, 15:14 by nuomi2...@gmail.com: > >> > >> > + > >> > +//fixme > >> > +static void vvc_refill2(CABACContext* c) { > >> >

Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

2024-01-02 Thread Lynne
Jan 2, 2024, 14:22 by nuomi2...@gmail.com: > On Mon, Jan 1, 2024 at 11:13 PM Lynne wrote: > >> >> >> >> Jan 1, 2024, 15:14 by nuomi2...@gmail.com: >> >> > + >> > +//fixme >> > +static void vvc_refill2(CABACContext* c) { >> > >> >> Fix what? >> Also, wrong coding style. >> > The function is a copy

Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

2024-01-02 Thread Nuo Mi
On Tue, Jan 2, 2024 at 1:35 AM Michael Niedermayer wrote: > On Mon, Jan 01, 2024 at 10:12:29PM +0800, Nuo Mi wrote: > > add Context-based Adaptive Binary Arithmetic Coding (CABAC) decoder > > > > Co-authored-by: Xu Mu > > Co-authored-by: Frank Plowman > > Co-authored-by: Shaun Loo > > Co-autho

Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

2024-01-02 Thread Nuo Mi
On Mon, Jan 1, 2024 at 11:13 PM Lynne wrote: > > > > Jan 1, 2024, 15:14 by nuomi2...@gmail.com: > > > + > > +//fixme > > +static void vvc_refill2(CABACContext* c) { > > > > Fix what? > Also, wrong coding style. > The function is a copy of refill2 in cabac_functions.h, including the style. The ref

Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

2024-01-01 Thread Michael Niedermayer
On Mon, Jan 01, 2024 at 10:12:29PM +0800, Nuo Mi wrote: > add Context-based Adaptive Binary Arithmetic Coding (CABAC) decoder > > Co-authored-by: Xu Mu > Co-authored-by: Frank Plowman > Co-authored-by: Shaun Loo > Co-authored-by: Wu Jianhua > --- > libavcodec/vvc/Makefile|4 +- > liba

Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

2024-01-01 Thread Lynne
Jan 1, 2024, 15:14 by nuomi2...@gmail.com: > + > +//fixme > +static void vvc_refill2(CABACContext* c) { > Fix what? Also, wrong coding style. > +int i; > +unsigned x; > +#if !HAVE_FAST_CLZ > +x = c->low ^ (c->low - 1); > +i = 7 - ff_h264_norm_shift[x >> (CABAC_BITS - 1)]; > +

[FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

2024-01-01 Thread Nuo Mi
add Context-based Adaptive Binary Arithmetic Coding (CABAC) decoder Co-authored-by: Xu Mu Co-authored-by: Frank Plowman Co-authored-by: Shaun Loo Co-authored-by: Wu Jianhua --- libavcodec/vvc/Makefile|4 +- libavcodec/vvc/vvc_cabac.c | 2478 libavc