Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-19 Thread Vittorio Giovara
gxu < > zhengxu.hu...@intel.com>; Jun Zhao ; Tmar, Hassene < > hassene.t...@intel.com> > Subject: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc > encoder wrapper. > > From: Jing Sun > > base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HE

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-18 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Jing SUN Sent: Monday, March 11, 2019 6:38 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Jun Zhao ; Tmar, Hassene Subject: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Sun, Jing A
On Wed, Mar 13, 2019 at 8:29 PM Sun, Jing A wrote: > > > > On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > wrote: > > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure > in the HEVC bitstream, but supports no interface for setting the color > properties b

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Vittorio Giovara
On Wed, Mar 13, 2019 at 8:29 PM Sun, Jing A wrote: > > > > On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > wrote: > > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure in > the HEVC bitstream, but supports no interface for setting the color > properties befo

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Sun, Jing A
> On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > mailto:jing.a@intel.com>> wrote: Hi Giovara, SVT HEVC has the interface to enable/disable sending a vui structure in the HEVC bitstream, but supports no interface for setting the color properties before encoding yet. I will be opening an iss

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-13 Thread Vittorio Giovara
On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A wrote: > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure in > the HEVC bitstream, but supports no interface for setting the color > properties before encoding yet. I will be opening an issue in SVT HEVC > github

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-12 Thread Sun, Jing A
On Monday, March 11, 2019 10:50 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: >On Mon, Mar 11, 2019 at 12:50 AM Sun, Jing A wrote: >I just searched my inbox again but failed to find that email of question you >mentioned. > >Yeah I often see my mail bounced with this message: > >Address

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-12 Thread Sun, Jing A
On Monday, March 11, 2019 10:50 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: >On Mon, Mar 11, 2019 at 12:50 AM Sun, Jing A wrote: >I just searched my inbox again but failed to find that email of question you >mentioned. > >Yeah I often see my mail bounced with this message: > >Address

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-12 Thread Sun, Jing A
] Sent: Monday, March 11, 2019 10:50 PM To: Sun, Jing A Cc: FFmpeg development discussions and patches ; Huang, Zhengxu ; Tmar, Hassene Subject: Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper. On Mon, Mar 11, 2019 at 12:50 AM Sun, Jing A mailto:jing.a

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Vittorio Giovara
On Mon, Mar 11, 2019 at 12:50 AM Sun, Jing A wrote: > I just searched my inbox again but failed to find that email of question > you mentioned. > Yeah I often see my mail bounced with this message: Address not foundYour message wasn't delivered to *jun.z...@intel.com* because the address couldn'

[FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Jing SUN
From: Jing Sun base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC V4: - Fix the build error with new API in PR#52 - Fix the encoding hang issue by API change in PR#52 - Fix the last frame dropping issue - Fix the invalid parameter causing segmentation fault issue

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Carl Eugen Hoyos
2019-03-11 11:28 GMT+01:00, Jing SUN : > +static void free_buffer(SvtContext *svt_enc) > +{ > +uint8_t *in_data = (EB_H265_ENC_INPUT *)svt_enc->in_buf.pBuffer; > + > +av_freep(&in_data); > +} Is the cast necessary? Does the variable make the code more readable? Does the function make the

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl Eugen Hoyos Sent: Monday, March 11, 2019 5:01 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

[FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Jing SUN
From: Jing Sun base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC V4: - Fix the build error with new API in PR#52 - Fix the encoding hang issue by API change in PR#52 - Fix the last frame dropping issue - Fix the invalid parameter causing segmentation fault issue

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Carl Eugen Hoyos
2019-03-11 9:49 GMT+01:00, Moritz Barsnick : > On Mon, Mar 11, 2019 at 04:17:21 +, Sun, Jing A wrote: >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Carl Eugen Hoyos >> > The condition is unnecessary. >> [SUN, Jing] If av_mallocz fails, free_buffer will be called

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Moritz Barsnick
On Mon, Mar 11, 2019 at 04:17:21 +, Sun, Jing A wrote: > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl > Eugen Hoyos > > The condition is unnecessary. > [SUN, Jing] If av_mallocz fails, free_buffer will be called with in_data > being NULL. Checking it avoids un

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-11 Thread Carl Eugen Hoyos
2019-03-11 5:17 GMT+01:00, Sun, Jing A : > 2019-03-08 11:36 GMT+01:00, Jing SUN : > >> +static void free_buffer(SvtContext *svt_enc) { >> +EB_H265_ENC_INPUT *in_data = >> (EB_H265_ENC_INPUT *)svt_enc->in_buf.pBuffer; > > Is the cast necessary? > Or actually: Can't in_data be whatever doesn't p

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-10 Thread Sun, Jing A
, 2019 4:48 AM To: FFmpeg development discussions and patches Cc: Sun, Jing A ; Huang, Zhengxu ; Jun Zhao ; Tmar, Hassene Subject: Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper. On Fri, Mar 8, 2019 at 4:39 AM Jing SUN mailto:jing.a@intel.com>> wrote

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-10 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl Eugen Hoyos Sent: Saturday, March 9, 2019 5:07 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-08 Thread Carl Eugen Hoyos
2019-03-08 11:36 GMT+01:00, Jing SUN : > +static void free_buffer(SvtContext *svt_enc) > +{ > +EB_H265_ENC_INPUT *in_data = > (EB_H265_ENC_INPUT *)svt_enc->in_buf.pBuffer; Is the cast necessary? Or actually: Can't in_data be whatever doesn't produce a warning? > + > +if (in_data) > +

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-08 Thread Vittorio Giovara
On Fri, Mar 8, 2019 at 4:39 AM Jing SUN wrote: > From: Jing Sun > > base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC > > V4: - Fix the build error with new API in PR#52 > - Fix the encoding hang issue by API change in PR#52 > - Fix the last frame dropping issue >

[FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

2019-03-08 Thread Jing SUN
From: Jing Sun base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC V4: - Fix the build error with new API in PR#52 - Fix the encoding hang issue by API change in PR#52 - Fix the last frame dropping issue - Fix the invalid parameter causing segmentation fault issue