Re: [FFmpeg-devel] [PATCH v7 06/12] swscale: organize and better document flags

2024-11-23 Thread Michael Niedermayer
On Thu, Nov 21, 2024 at 01:06:20PM +0100, Niklas Haas wrote: > On Thu, 21 Nov 2024 01:26:36 +0100 Michael Niedermayer > wrote: > > Hi > > > > > > On Sat, Nov 16, 2024 at 12:25:01PM +0100, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > Group them into an enum rather than random #defines,

Re: [FFmpeg-devel] [PATCH v7 06/12] swscale: organize and better document flags

2024-11-21 Thread Niklas Haas
On Thu, 21 Nov 2024 01:26:36 +0100 Michael Niedermayer wrote: > Hi > > > On Sat, Nov 16, 2024 at 12:25:01PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > Group them into an enum rather than random #defines, and document their > > behavior a bit more obviously. > > > > > Of particular n

Re: [FFmpeg-devel] [PATCH v7 06/12] swscale: organize and better document flags

2024-11-20 Thread Michael Niedermayer
Hi On Sat, Nov 16, 2024 at 12:25:01PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Group them into an enum rather than random #defines, and document their > behavior a bit more obviously. > > Of particular note, I discovered that SWS_DIRECT_BGR is not referenced > anywhere else in the co

[FFmpeg-devel] [PATCH v7 06/12] swscale: organize and better document flags

2024-11-16 Thread Niklas Haas
From: Niklas Haas Group them into an enum rather than random #defines, and document their behavior a bit more obviously. Of particular note, I discovered that SWS_DIRECT_BGR is not referenced anywhere else in the code base. As such, I have moved it to the deprecated section, alongside SWS_ERROR_