Aug 27, 2020, 10:17 by barsn...@gmx.net:
> On Wed, Aug 26, 2020 at 16:31:46 +, Anamitra Ghorui wrote:
>
>> >> +uint8_t ff_flif16_rac_read_bit(FLIF16RangeCoder *rc,
>> >> + uint8_t *target)
>> >> +{
>> >> +return ff_flif16_rac_get(rc, rc->range >> 1, target);
>
Moritz Barsnick (12020-08-27):
> I understand this justification. I just wanted to point out that the
> code was not parsable to my brain, due to the macros (which I do
> relaize have "goto"s in them, which is okay to me) and the "case"
> labels in the middle of code blocks.
>
> I suggest others c
Lynne (12020-08-27):
> We always inline bitstream reading functions, and this one is no different.
> Its really necessary for speed, and well worth the additional binary size.
> There's no memory cache gains to be had here, not with the huge
> several hundred instruction lookaheads modern CPUs have
On Wed, Aug 26, 2020 at 16:31:46 +, Anamitra Ghorui wrote:
> >> +uint8_t ff_flif16_rac_read_bit(FLIF16RangeCoder *rc,
> >> + uint8_t *target)
> >> +{
> >> +return ff_flif16_rac_get(rc, rc->range >> 1, target);
> >> +}
> >
> > If this is called often, you may wa
On Thu, 27 Aug 2020 08:46:00 +0530
Anamitra Ghorui wrote:
> (I apologise if this mail gets sent to the wrong thread and other
> errors. I'm trying out a new mail client)
>
> On Wed, 26 Aug 2020 16:31:46 +
> "Anamitra Ghorui" wrote:
>
> [...]
>
> > I agree that the case statements between
(I apologise if this mail gets sent to the wrong thread and other
errors. I'm trying out a new mail client)
On Wed, 26 Aug 2020 16:31:46 +
"Anamitra Ghorui" wrote:
[...]
> I agree that the case statements between if statements and while
> statements are not very good looking, but this allow
Hello,
Thanks for the review. Please see replies below.
On 26/08/2020 18:44, Moritz Barsnick wrote:
> On Sun, Aug 23, 2020 at 00:09:32 +0530, Anamitra Ghorui wrote:
>> v2: Fix faulty patch
>> v3: Fix addressed errors, Add interlaced decoding support
>> v4: Fix Further cosmetics, C.Bucket Transform
On Sun, Aug 23, 2020 at 00:09:32 +0530, Anamitra Ghorui wrote:
> v2: Fix faulty patch
> v3: Fix addressed errors, Add interlaced decoding support
> v4: Fix Further cosmetics, C.Bucket Transform reading errors, Atomise patch
> v5: Fix faulty patch
> v6: Address pointed out errors, use av_freep every
