Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021 at 4:52 PM Jan Ekström wrote: > > On Thu, Mar 4, 2021, 16:43 Moritz Barsnick wrote: >> >> On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: >> > I... just am not so sure in this case splitting the TTML writer and >> > the TTML encoder from each other makes sense. >> >

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021, 16:43 Moritz Barsnick wrote: > On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: > > I... just am not so sure in this case splitting the TTML writer and > > the TTML encoder from each other makes sense. > > I agree. In very many cases, muxer and encoder, or demuxer a

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Moritz Barsnick
On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: > I... just am not so sure in this case splitting the TTML writer and > the TTML encoder from each other makes sense. I agree. In very many cases, muxer and encoder, or demuxer and decoder are only useful together. Yet I have observed tha

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021 at 11:57 AM Moritz Barsnick wrote: > > On Wed, Mar 03, 2021 at 22:09:12 +0200, Jan Ekström wrote: > > Thus, I will be pulling this set in Soon (probably tomorrow). Thus if > > anyone still wishes to have a say, I recommend doing it earlier than > > later. > > > + * Copyright (c

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Moritz Barsnick
On Wed, Mar 03, 2021 at 22:09:12 +0200, Jan Ekström wrote: > Thus, I will be pulling this set in Soon (probably tomorrow). Thus if > anyone still wishes to have a say, I recommend doing it earlier than > later. > + * Copyright (c) 2020 24i Is 24i a company? Just wondering. Also, I'm not sure whe

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-03 Thread Jan Ekström
On Tue, Mar 2, 2021 at 11:00 AM Jan Ekström wrote: > > I've intentionally kept this initial version simple (no styling etc) to focus > on the basics. As this goes through review, additional features can be added > (I had initial PoC for styling implemented some time around previous VDD), and > the

[FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-02 Thread Jan Ekström
I've intentionally kept this initial version simple (no styling etc) to focus on the basics. As this goes through review, additional features can be added (I had initial PoC for styling implemented some time around previous VDD), and there is another patch set in my queue which would then add suppo