Re: [FFmpeg-devel] [PATCH v5] Add support for Audible AA files

2015-07-30 Thread Vesselin Bontchev
30.07.2015, 11:35, "Carl Eugen Hoyos" : > Vesselin Bontchev yandex.com> writes: >>  + if (c->aa_fixed_key_size != 16) { >>  // AVOption with a default value > > Again: Where is this variable set? > You don't have to add a comment, just > tell me, I don't see it. +#define OFFSET(x) offsetof(AADe

Re: [FFmpeg-devel] [PATCH v5] Add support for Audible AA files

2015-07-30 Thread Carl Eugen Hoyos
Vesselin Bontchev yandex.com> writes: > Is the licensing blurb okay now? No objections from me, the "This file is part of" may be unnecessary. > +avio_read(pb, key, nkey); // key string I may miss something but I wonder if there isn't a check missing if nkey is sane and if pb is long en

Re: [FFmpeg-devel] [PATCH v5] Add support for Audible AA files

2015-07-29 Thread Vesselin Bontchev
28.07.2015, 20:09, "Vesselin Bontchev" : > I sneaked in some more fixes in this revision :) Hi Carl, Is the licensing blurb okay now? All, Hopefully, the code is now good enough to be merged. All feedback is welcome! Thanks, Vesselin ___ ffmpeg-devel

[FFmpeg-devel] [PATCH v5] Add support for Audible AA files

2015-07-28 Thread Vesselin Bontchev
I sneaked in some more fixes in this revision :) VesselinFrom 5db4be22af277030cdbe234843e7aae55bf667e1 Mon Sep 17 00:00:00 2001 From: Vesselin Bontchev Date: Sun, 19 Jul 2015 23:16:36 +0200 Subject: [PATCH] Add support for Audible AA files https://en.wikipedia.org/wiki/Audible.com#Quality --- d