Re: [FFmpeg-devel] [PATCH v4 7/9] avformat/utils: Avoid copying packets unnecessarily

2019-09-28 Thread Andreas Rheinhardt
James Almer: > On 9/27/2019 11:52 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: Up until now, read_frame_internal in avformat/utils.c uses a spare packet on the stack that serves no real purpose: At no point in this function is ther

Re: [FFmpeg-devel] [PATCH v4 7/9] avformat/utils: Avoid copying packets unnecessarily

2019-09-28 Thread James Almer
On 9/27/2019 11:52 PM, Andreas Rheinhardt wrote: > James Almer: >> On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: >>> Up until now, read_frame_internal in avformat/utils.c uses a spare >>> packet on the stack that serves no real purpose: At no point in this >>> function is there a need for another

Re: [FFmpeg-devel] [PATCH v4 7/9] avformat/utils: Avoid copying packets unnecessarily

2019-09-27 Thread Andreas Rheinhardt
James Almer: > On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: >> Up until now, read_frame_internal in avformat/utils.c uses a spare >> packet on the stack that serves no real purpose: At no point in this >> function is there a need for another packet besides the packet destined >> for output: >> 1

Re: [FFmpeg-devel] [PATCH v4 7/9] avformat/utils: Avoid copying packets unnecessarily

2019-09-26 Thread James Almer
On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: > Up until now, read_frame_internal in avformat/utils.c uses a spare > packet on the stack that serves no real purpose: At no point in this > function is there a need for another packet besides the packet destined > for output: > 1. If the packet does

[FFmpeg-devel] [PATCH v4 7/9] avformat/utils: Avoid copying packets unnecessarily

2019-09-20 Thread Andreas Rheinhardt
Up until now, read_frame_internal in avformat/utils.c uses a spare packet on the stack that serves no real purpose: At no point in this function is there a need for another packet besides the packet destined for output: 1. If the packet doesn't need a parser, but is output as is, the content of the