Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

2021-04-24 Thread Zane van Iperen
On 25/4/21 11:41 am, Zane van Iperen wrote: Interesting, FATE didn't catch it for me. Which test is it? $ make fate-adpcm fate-acodec fate-westwood-aud SAMPLES=fate-suite/ All pass for me. Never mind, found it. Both the sample from the ticket as well as the fate-sample (vqa/cc-demo1-pa

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

2021-04-24 Thread Zane van Iperen
On 25/4/21 11:02 am, Andreas Rheinhardt wrote: Zane van Iperen: On 25/4/21 9:40 am, Andreas Rheinhardt wrote: This format is covered by FATE (namely the adpcm-ima-ws test) and so you need to update the checksums in your patch; of course you should verify that your change is correct. See h

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

2021-04-24 Thread Andreas Rheinhardt
Zane van Iperen: > > > On 25/4/21 9:40 am, Andreas Rheinhardt wrote: > >> This format is covered by FATE (namely the adpcm-ima-ws test) and so you >> need to update the checksums in your patch; of course you should verify >> that your change is correct. See https://ffmpeg.org/fate.html for more.

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

2021-04-24 Thread Zane van Iperen
On 25/4/21 9:40 am, Andreas Rheinhardt wrote: This format is covered by FATE (namely the adpcm-ima-ws test) and so you need to update the checksums in your patch; of course you should verify that your change is correct. See https://ffmpeg.org/fate.html for more. - Andreas ___

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

2021-04-24 Thread Andreas Rheinhardt
Aidan Richmond: > Fixes bug #9198 > > Signed-off-by: Aidan Richmond > --- > libavcodec/adpcm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index be14607eac..5ec9691001 100644 > --- a/libavcodec/adpcm.c > +++ b/libavcod

[FFmpeg-devel] [PATCH v4 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

2021-04-24 Thread Aidan Richmond
Fixes bug #9198 Signed-off-by: Aidan Richmond --- libavcodec/adpcm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index be14607eac..5ec9691001 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1400,16 +1400,16 @@ sta