Re: [FFmpeg-devel] [PATCH v4 3/3] aadec: improve seeking in mp3 content

2018-07-11 Thread Karsten Otto
> Am 11.07.2018 um 20:09 schrieb Michael Niedermayer : > > Signierter PGP-Teil > On Sat, Jul 07, 2018 at 07:41:29PM +0200, Karsten Otto wrote: >> MP3 frames may not be aligned to aa chunk boundaries. When seeking, >> calculate the expected frame offset in the target chunk. Adjust the >> timestamp

Re: [FFmpeg-devel] [PATCH v4 3/3] aadec: improve seeking in mp3 content

2018-07-11 Thread Michael Niedermayer
On Sat, Jul 07, 2018 at 07:41:29PM +0200, Karsten Otto wrote: > MP3 frames may not be aligned to aa chunk boundaries. When seeking, > calculate the expected frame offset in the target chunk. Adjust the > timestamp and truncate the next packet accordingly. > > This solution works for the majority o

Re: [FFmpeg-devel] [PATCH v4 3/3] aadec: improve seeking in mp3 content

2018-07-10 Thread Karsten Otto
Ping - What about this one? I tested it with about 20 files and it works perfectly for all of them - except one which has tag/padding. In its case, playback quality is virtually the same as without the patch, i.e. no harm done. Cheers, Karsten > Am 07.07.2018 um 19:41 schrieb Karsten Otto : >

[FFmpeg-devel] [PATCH v4 3/3] aadec: improve seeking in mp3 content

2018-07-07 Thread Karsten Otto
MP3 frames may not be aligned to aa chunk boundaries. When seeking, calculate the expected frame offset in the target chunk. Adjust the timestamp and truncate the next packet accordingly. This solution works for the majority of tested audio material. For some rare encodings with mp3 padding or emb