Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On 03/02/2016 11:19 PM, Mats Peterson wrote: On 03/02/2016 11:07 PM, Mats Peterson wrote: On 03/02/2016 10:30 PM, Michael Niedermayer wrote: +ret = 0; +if (trk->enc->pix_fmt == AV_PIX_FMT_PAL8 && !trk->pal_done) { +const uint8_t *pal; +

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On 03/02/2016 11:07 PM, Mats Peterson wrote: On 03/02/2016 10:30 PM, Michael Niedermayer wrote: +ret = 0; +if (trk->enc->pix_fmt == AV_PIX_FMT_PAL8 && !trk->pal_done) { +const uint8_t *pal; +int ret2 = ff_get_packet_palette(s, opkt, ret

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On 03/02/2016 10:30 PM, Michael Niedermayer wrote: +ret = 0; +if (trk->enc->pix_fmt == AV_PIX_FMT_PAL8 && !trk->pal_done) { +const uint8_t *pal; +int ret2 = ff_get_packet_palette(s, opkt, ret, &pal); +if (ret2 < 0) +

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On 03/02/2016 09:36 PM, Michael Niedermayer wrote: in which cases of compressed (non raw) video does doing something special for pix_fmt == pal8 fix a problem ? In several cases. QuickTime RLE in 8-bit mode, QuickTime Graphics (SMC) in 8-bit mode, Microsoft Video 1 (CRAM) in 8-bit mode. All o

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On Wed, Mar 02, 2016 at 08:33:42PM +0100, Mats Peterson wrote: > Check that the track type is AVMEDIA_TYPE_VIDEO in appropriate places. > > -- > Mats Peterson > http://matsp888.no-ip.org/~mats/ > movenc.c | 45 +++-- > 1 file changed, 27 insertions(+),

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On Wed, Mar 02, 2016 at 09:24:37PM +0100, Mats Peterson wrote: > On 03/02/2016 09:23 PM, Mats Peterson wrote: > >On 03/02/2016 09:21 PM, Michael Niedermayer wrote: > >>On Wed, Mar 02, 2016 at 08:33:42PM +0100, Mats Peterson wrote: > >>>Check that the track type is AVMEDIA_TYPE_VIDEO in appropriate

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On Wed, Mar 02, 2016 at 09:23:40PM +0100, Mats Peterson wrote: > On 03/02/2016 09:21 PM, Michael Niedermayer wrote: > >On Wed, Mar 02, 2016 at 08:33:42PM +0100, Mats Peterson wrote: > >>Check that the track type is AVMEDIA_TYPE_VIDEO in appropriate places. > >> > >>-- > >>Mats Peterson > >>http://m

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On 03/02/2016 09:23 PM, Mats Peterson wrote: On 03/02/2016 09:21 PM, Michael Niedermayer wrote: On Wed, Mar 02, 2016 at 08:33:42PM +0100, Mats Peterson wrote: Check that the track type is AVMEDIA_TYPE_VIDEO in appropriate places. -- Mats Peterson http://matsp888.no-ip.org/~mats/ movenc.c

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On 03/02/2016 09:21 PM, Michael Niedermayer wrote: On Wed, Mar 02, 2016 at 08:33:42PM +0100, Mats Peterson wrote: Check that the track type is AVMEDIA_TYPE_VIDEO in appropriate places. -- Mats Peterson http://matsp888.no-ip.org/~mats/ movenc.c | 45 +++

Re: [FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

On Wed, Mar 02, 2016 at 08:33:42PM +0100, Mats Peterson wrote: > Check that the track type is AVMEDIA_TYPE_VIDEO in appropriate places. > > -- > Mats Peterson > http://matsp888.no-ip.org/~mats/ > movenc.c | 45 +++-- > 1 file changed, 27 insertions(+),

[FFmpeg-devel] [PATCH v4 2/5 v2] lavf/movenc: Add support for palette side data

Check that the track type is AVMEDIA_TYPE_VIDEO in appropriate places. -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From c2d0b7a69486afb926e731216b4aff3b04c4ee4a Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Wed, 2 Mar 2016 20:30:59 +0100 Subject: [PATCH v4 2/5 v2] lavf/movenc: Add su