> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Nicolas George
> Sent: Montag, 21. April 2025 19:21
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat:
> Quality i
> -Original Message-
> From: Stefano Sabatini
> Sent: Montag, 21. April 2025 19:17
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Cc: softworkz
> Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat:
> Quality improvements
>
Stefano Sabatini (HE12025-04-21):
> > +if (!pwctx || !avio_ctx)
> > +return AVERROR(EINVAL);
> > +
> maybe warning in this case as well
Checking that an argument that must not be null is not null is the
responsibility of the caller: crashing here is the right thing to do,
same as fprin
On date Sunday 2025-04-20 22:59:05 +, softworkz wrote:
> From: softworkz
>
Nazigrammar commit log nit: use verb to specify the change action,
like in: apply quality improvements
Also probably want to have some more details below the headline,
like:
Perform multiple improvements to increase
From: softworkz
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.c | 111 +++---
fftools/textformat/avtextformat.h | 6 +-
fftools/textformat/tf_default.c | 8 ++-
fftools/textformat/tf_ini.c | 2 +-
fftools/textformat/tf_json.c | 8 ++-
