Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Devin Heitmueller
> On Feb 8, 2019, at 9:47 AM, Mathieu Duponchelle > wrote: > > On 2/8/19 11:58 AM, Michael Niedermayer wrote: >> what if size is not a multiple of 3 ? > > Good point, more bytes will be written than advertised. Do you reckon > the input should be straight up refused? The other solution is to wa

Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Mathieu Duponchelle
On 2/8/19 11:58 AM, Michael Niedermayer wrote: > what if size is not a multiple of 3 ? Good point, more bytes will be written than advertised. Do you reckon the input should be straight up refused? The other solution is to warn then iterate over side_data->size rounded down to the closest 3 multip

Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Michael Niedermayer
On Thu, Feb 07, 2019 at 09:03:16PM +0100, Mathieu Duponchelle wrote: > --- > doc/encoders.texi | 3 +++ > libavcodec/mpeg12enc.c | 31 +++ > libavcodec/mpegvideo.h | 2 ++ > 3 files changed, 36 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi

[FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

2019-02-07 Thread Mathieu Duponchelle
--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 31 +++ libavcodec/mpegvideo.h | 2 ++ 3 files changed, 36 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++ b/doc/encoders.tex