Quoting SuperFashi (2023-05-01 03:10:36)
> Thanks for the feedback. I thought across libraries meant across different
> muxers/demuxers. In which case, is there any naming scheme for functions
> that are only used within lavf? Can i just remove the avpriv_ prefix?
tl;dr: use ff_ for non-static fun
Thanks for the feedback. I thought across libraries meant across different
muxers/demuxers. In which case, is there any naming scheme for functions
that are only used within lavf? Can i just remove the avpriv_ prefix?
For inline, my habit is to add it when there’s only one place that uses it.
I ca
Quoting SuperFashi (2023-04-30 05:32:46)
> Thanks. Is there anything else that does not fit codebase tradition? Please
> point everything out so I could send a new patch.
Some quick notes:
* why are there avpriv_ functions when everything you do is libavformat?
avpriv is for sharing functions ac
Thanks. Is there anything else that does not fit codebase tradition? Please
point everything out so I could send a new patch.
On Sun, Apr 30, 2023 at 3:06 AM Michael Niedermayer
wrote:
> On Sat, Apr 29, 2023 at 02:53:06PM +0900, SuperFashi wrote:
> > v1 -> v2: Refactor using GetByteContext; Fix
On Sat, Apr 29, 2023 at 02:53:06PM +0900, SuperFashi wrote:
> v1 -> v2: Refactor using GetByteContext; Fix compile error.
> v2 -> v3: Remove debug statement.
> v3 -> v4: Squash commits (sorry, first time git patch user :(
>
> This patch adds an MPEG Media Transport Protocol (MMTP) parser, as defin
v1 -> v2: Refactor using GetByteContext; Fix compile error.
v2 -> v3: Remove debug statement.
v3 -> v4: Squash commits (sorry, first time git patch user :(
This patch adds an MPEG Media Transport Protocol (MMTP) parser, as defined in
ISO/IEC 23008-1, and an MMT protocol over TLV packets (MMT/TLV)