Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-07 Thread Karsten Otto
> Am 06.07.2018 um 23:32 schrieb Michael Niedermayer : > > Signierter PGP-Teil > On Fri, Jul 06, 2018 at 10:49:46AM +0200, Karsten Otto wrote: >> >>> Am 04.07.2018 um 23:54 schrieb Michael Niedermayer : >>> >>> Signierter PGP-Teil >>> On Wed, Jul 04, 2018 at 09:32:32AM +0200, Karsten Otto wrote

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-06 Thread Michael Niedermayer
On Fri, Jul 06, 2018 at 10:49:46AM +0200, Karsten Otto wrote: > > > Am 04.07.2018 um 23:54 schrieb Michael Niedermayer : > > > > Signierter PGP-Teil > > On Wed, Jul 04, 2018 at 09:32:32AM +0200, Karsten Otto wrote: > >> > >>> Am 04.07.2018 um 03:26 schrieb Michael Niedermayer > >>> : > >>> > >

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-06 Thread Karsten Otto
> Am 04.07.2018 um 23:54 schrieb Michael Niedermayer : > > Signierter PGP-Teil > On Wed, Jul 04, 2018 at 09:32:32AM +0200, Karsten Otto wrote: >> >>> Am 04.07.2018 um 03:26 schrieb Michael Niedermayer : >>> >>> Signierter PGP-Teil >>> On Tue, Jul 03, 2018 at 10:25:36PM +0200, Karsten Otto wrote

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-04 Thread Michael Niedermayer
On Wed, Jul 04, 2018 at 09:32:32AM +0200, Karsten Otto wrote: > > > Am 04.07.2018 um 03:26 schrieb Michael Niedermayer : > > > > Signierter PGP-Teil > > On Tue, Jul 03, 2018 at 10:25:36PM +0200, Karsten Otto wrote: > >> TL;DR: I will drop patch 3/3, may rather spend some time investigating why >

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-04 Thread Karsten Otto
> Am 04.07.2018 um 03:26 schrieb Michael Niedermayer : > > Signierter PGP-Teil > On Tue, Jul 03, 2018 at 10:25:36PM +0200, Karsten Otto wrote: >> TL;DR: I will drop patch 3/3, may rather spend some time investigating why >> "ff ee 47 9d“ passes the mp3 header parser. Also, the aa file "index" can

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-03 Thread Michael Niedermayer
On Tue, Jul 03, 2018 at 10:25:36PM +0200, Karsten Otto wrote: > TL;DR: I will drop patch 3/3, may rather spend some time investigating why > "ff ee 47 9d“ passes the mp3 header parser. Also, the aa file "index" cannot > be used for frame or chapter detection, unfortunately. > > More details inline

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-03 Thread Karsten Otto
> Am 03.07.2018 um 22:29 schrieb Carl Eugen Hoyos : > > 2018-07-03 22:25 GMT+02:00, Karsten Otto : > >> It took a closer look at what happens when I hear a BLEEP: The packet begins >> with a partial frame, starting with the byte sequence "ff ee 47 9d“. >> Unfortunately, >> the mp3 parser indeed

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-03 Thread Carl Eugen Hoyos
2018-07-03 22:25 GMT+02:00, Karsten Otto : > It took a closer look at what happens when I hear a BLEEP: The packet begins > with a partial frame, starting with the byte sequence "ff ee 47 9d“. > Unfortunately, > the mp3 parser indeed accepts this as a valid mp3 header, causing the noise. > By look

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-03 Thread Karsten Otto
TL;DR: I will drop patch 3/3, may rather spend some time investigating why "ff ee 47 9d“ passes the mp3 header parser. Also, the aa file "index" cannot be used for frame or chapter detection, unfortunately. More details inline below. > Am 03.07.2018 um 02:32 schrieb Michael Niedermayer : > > Si

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-02 Thread Michael Niedermayer
On Mon, Jul 02, 2018 at 07:21:43PM +0200, Karsten Otto wrote: > > > Am 02.07.2018 um 10:59 schrieb Michael Niedermayer : > > > > Signierter PGP-Teil > > On Thu, Jun 21, 2018 at 06:58:26PM +0200, Karsten Otto wrote: > >> MP3 frames may not be aligned to aa chunk boundaries. After seeking, > >> sca

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-02 Thread Karsten Otto
> Am 02.07.2018 um 10:59 schrieb Michael Niedermayer : > > Signierter PGP-Teil > On Thu, Jun 21, 2018 at 06:58:26PM +0200, Karsten Otto wrote: >> MP3 frames may not be aligned to aa chunk boundaries. After seeking, >> scan for the next valid frame header. Then truncate the packet, and >> also adj

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-07-02 Thread Michael Niedermayer
On Thu, Jun 21, 2018 at 06:58:26PM +0200, Karsten Otto wrote: > MP3 frames may not be aligned to aa chunk boundaries. After seeking, > scan for the next valid frame header. Then truncate the packet, and > also adjust timestamp information accordingly. > --- > libavformat/aadec.c | 33 +

[FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

2018-06-21 Thread Karsten Otto
MP3 frames may not be aligned to aa chunk boundaries. After seeking, scan for the next valid frame header. Then truncate the packet, and also adjust timestamp information accordingly. --- libavformat/aadec.c | 33 - 1 file changed, 28 insertions(+), 5 deletions(-)