On 8/13/2020 11:45 PM, Xu, Guangxin wrote:
>> Should be good with those trivial changes, so i can implement them and push
>> if
>> you don't want to send another revision.
>>
> Great! thanks for you kindly help on this and previous review.
> Really appreciate it.
Applied those changes, added miss
: [FFmpeg-devel] [PATCH v3 2/3] avormat/av1dec: add low-
> overhead bitstream format
>
> On Thu, 13 Aug 2020, James Almer wrote:
>
> > On 8/13/2020 3:51 AM, Xu Guangxin wrote:
>
> >> +
> >> +ret = obu_prefetch(s, header, MAX_OBU_HEADER_SIZE);
> &g
James
> Almer
> Sent: Friday, August 14, 2020 3:11 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v3 2/3] avormat/av1dec: add low-
> overhead bitstream format
>
> On 8/13/2020 3:51 AM, Xu Guangxin wrote:
> > Hi James,
> > thanks for your feed
On Thu, 13 Aug 2020, James Almer wrote:
On 8/13/2020 3:51 AM, Xu Guangxin wrote:
+
+ret = obu_prefetch(s, header, MAX_OBU_HEADER_SIZE);
+if (!ret)
+return AVERROR(EOF);
We use AVERROR_EOF rather than AVERROR(EOF) (Afair, it was done because
EOF is not portable, but don't quo
On 8/13/2020 3:51 AM, Xu Guangxin wrote:
> Hi James,
> thanks for your feedback, please help review it again.
>
> Changelist for v3:
> use av_fifo_* instead of homebrewed fifo operations
> obu_probe(), add padding obu to alllow list
> read_header(), use "const AVRational* framerate" instead
Hi James,
thanks for your feedback, please help review it again.
Changelist for v3:
use av_fifo_* instead of homebrewed fifo operations
obu_probe(), add padding obu to alllow list
read_header(), use "const AVRational* framerate" instead of "AVRational
framerate"
It's defined in Section
