Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-20 Thread Leo Izen
On 4/20/23 05:50, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 05:15:00PM -0400, Leo Izen wrote: On 4/19/23 16:37, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 03:23:41PM -0400, Leo Izen wrote: On 4/19/23 14:58, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 02:11:24PM -0400,

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-20 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 05:15:00PM -0400, Leo Izen wrote: > On 4/19/23 16:37, Michael Niedermayer wrote: > > On Wed, Apr 19, 2023 at 03:23:41PM -0400, Leo Izen wrote: > > > On 4/19/23 14:58, Michael Niedermayer wrote: > > > > On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: > > > > > The c

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Caleb Etemesi
if the problem you are trying to solve is upsampling, the agreed samples are usually 422,444 and 420 (Y,Cb,Cr order) but there can be files with sampling factors like 242, since the jfif spec isn't to restrictive on what sampling factors are allowed,libjpeg(and it's cousin libjpeg-turbo) support s

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Leo Izen
On 4/19/23 16:37, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 03:23:41PM -0400, Leo Izen wrote: On 4/19/23 14:58, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 created a regression f

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 03:23:41PM -0400, Leo Izen wrote: > On 4/19/23 14:58, Michael Niedermayer wrote: > > On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: > > > The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 > > > created a regression for non-subsampled progressive RG

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Leo Izen
On 4/19/23 14:58, Michael Niedermayer wrote: On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 created a regression for non-subsampled progressive RGB jpegs. This should fix that. --- libavcodec/mjpegdec.c | 3 ++- 1 fi

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Michael Niedermayer
On Wed, Apr 19, 2023 at 02:11:24PM -0400, Leo Izen wrote: > The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 > created a regression for non-subsampled progressive RGB jpegs. This > should fix that. > --- > libavcodec/mjpegdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletio

[FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-19 Thread Leo Izen
The change introduced in b18a9c29713abc3a1b081de3f320ab53a47120c6 created a regression for non-subsampled progressive RGB jpegs. This should fix that. --- libavcodec/mjpegdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index