Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Zane van Iperen
On Sun, 12 Apr 2020 16:38:06 +0200 "Paul B Mahol" wrote: > On 4/12/20, Zane van Iperen wrote: > > On Sun, 12 Apr 2020 15:01:39 +0200 > > "Paul B Mahol" wrote: > > > >> > > >> > I probably should have mentioned that yes, I had already added > >> > the appropriate SSI code to adpcm_compress_tre

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Paul B Mahol
On 4/12/20, Zane van Iperen wrote: > On Sun, 12 Apr 2020 15:01:39 +0200 > "Paul B Mahol" wrote: > >> > >> > I probably should have mentioned that yes, I had already added the >> > appropriate SSI code to adpcm_compress_trellis(). >> >> The one that updates node predictor? >> > >> > > Yep, whereve

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Zane van Iperen
On Sun, 12 Apr 2020 15:01:39 +0200 "Paul B Mahol" wrote: > > > > I probably should have mentioned that yes, I had already added the > > appropriate SSI code to adpcm_compress_trellis(). > > The one that updates node predictor? > > > > Yep, wherever there was a check for QT, I added a check for

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Paul B Mahol
On 4/12/20, Zane van Iperen wrote: > On Sun, 12 Apr 2020 11:41:40 +0200 > "Paul B Mahol" wrote: > >> On 4/12/20, Zane van Iperen wrote: >> > On Sat, 11 Apr 2020 22:02:26 +0200 >> > "Paul B Mahol" wrote: >> > >> >> > >> >> > Ping. >> >> > >> >> > Also, could someone please clarify something for

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Zane van Iperen
On Sun, 12 Apr 2020 11:41:40 +0200 "Paul B Mahol" wrote: > On 4/12/20, Zane van Iperen wrote: > > On Sat, 11 Apr 2020 22:02:26 +0200 > > "Paul B Mahol" wrote: > > > >> > > >> > Ping. > >> > > >> > Also, could someone please clarify something for me? > >> > > >> > When encoding, there's no inh

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Paul B Mahol
On 4/12/20, Zane van Iperen wrote: > On Sat, 11 Apr 2020 22:02:26 +0200 > "Paul B Mahol" wrote: > >> > >> > Ping. >> > >> > Also, could someone please clarify something for me? >> > >> > When encoding, there's no inherit differences between trellis and >> > non-trellis other then a potentially mo

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Zane van Iperen
On Sat, 11 Apr 2020 22:02:26 +0200 "Paul B Mahol" wrote: > > > > Ping. > > > > Also, could someone please clarify something for me? > > > > When encoding, there's no inherit differences between trellis and > > non-trellis other then a potentially more-accurate set of nibbles? > > > > And the deco

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-11 Thread Paul B Mahol
On 4/11/20, Zane van Iperen wrote: > On Fri, 10 Apr 2020 12:26:50 + > "Zane van Iperen" wrote: > >> Signed-off-by: Zane van Iperen >> --- >> Changelog | 1 + >> doc/general.texi | 2 +- >> libavcodec/Makefile| 1 + >> libavcodec/adpcmenc.c | 30 +++

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-11 Thread Zane van Iperen
On Fri, 10 Apr 2020 12:26:50 + "Zane van Iperen" wrote: > Signed-off-by: Zane van Iperen > --- > Changelog | 1 + > doc/general.texi | 2 +- > libavcodec/Makefile| 1 + > libavcodec/adpcmenc.c | 30 ++ > libavcodec/allcodecs.c | 1 + >

[FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-10 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 30 ++ libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 7 files change