Re: [FFmpeg-devel] [PATCH v3] libxvid: Create extradata in init using a dummy frame

2016-04-05 Thread Derek Buitenhuis
On 4/5/2016 10:26 AM, Michael Niedermayer wrote: > should be ok fro ffmpegs side, i dont know the xvid API As far as I can tell from its documentation, this is the official / correct way. The API is kinda bad in that sense. Thanks, - Derek ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH v3] libxvid: Create extradata in init using a dummy frame

2016-04-05 Thread Michael Niedermayer
On Mon, Apr 04, 2016 at 03:59:27PM -0400, Derek Buitenhuis wrote: > Modifying global header extradata in encode_frame is an API violation > and only happens to work currently because mov writes its header > at the end of the file. > > Heavily based off of a patch from 2012. > > Original-by: Nicol

[FFmpeg-devel] [PATCH v3] libxvid: Create extradata in init using a dummy frame

2016-04-04 Thread Derek Buitenhuis
Modifying global header extradata in encode_frame is an API violation and only happens to work currently because mov writes its header at the end of the file. Heavily based off of a patch from 2012. Original-by: Nicolas George Signed-off-by: Derek Buitenhuis --- libavcodec/libxvid.c | 40 +