Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: add dash demuxer base version

2017-03-20 Thread Michael Niedermayer
On Mon, Mar 20, 2017 at 10:29:48PM +0800, Steven Liu wrote: [...] > +static int parse_mainifest_segmenttimeline(AVFormatContext *s, struct > representation *rep, > + xmlNodePtr fragment_timeline_node) > +{ > +xmlAttrPtr attr = NULL; > +xmlChar *val

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: add dash demuxer base version

2017-03-20 Thread Ricardo Constantino
Also, 'manifest' seems to be typo'd through the patch to 'mainifest'. Not sure if intended. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: add dash demuxer base version

2017-03-20 Thread Clément Bœsch
On Mon, Mar 20, 2017 at 10:29:48PM +0800, Steven Liu wrote: > v2 fixed: > 1. from autodetect to disabled > 2. from camelCase code style to ffmpeg code style > 3. from RepType to AVMediaType > 4. fix variable typo > 5. change time value from uint32_t to uint64_t > 6. removed be used once API > 7. ch

[FFmpeg-devel] [PATCH v3] avformat/dashdec: add dash demuxer base version

2017-03-20 Thread Steven Liu
v2 fixed: 1. from autodetect to disabled 2. from camelCase code style to ffmpeg code style 3. from RepType to AVMediaType 4. fix variable typo 5. change time value from uint32_t to uint64_t 6. removed be used once API 7. change 'time(NULL)`, except it is not 2038-safe.' to av_gettime and av_timegm