Yes, all your suggestions silence the errors. Thanks!
- dale
On Fri, Oct 26, 2018 at 4:05 PM James Almer wrote:
> On 10/26/2018 7:31 PM, Dale Curtis wrote:
> > The following warnings show up when compiling with clang:
> > ../../third_party/ffmpeg/libavcodec/libdav1d.c:92:24: error: suggest
> br
On Fri, Oct 26, 2018 at 4:00 PM James Almer wrote:
> On 10/26/2018 7:50 PM, Dale Curtis wrote:
> > One more piece of feedback, this is not obeying the
> > AVCodecContext.get_buffer2 API.
>
> It's not using it on purpose, wrapping the buffers dav1d allocated
> itself instead. Hence the lack of AV_
On 10/26/2018 7:31 PM, Dale Curtis wrote:
> The following warnings show up when compiling with clang:
> ../../third_party/ffmpeg/libavcodec/libdav1d.c:92:24: error: suggest braces
> around initialization of subobject [-Werror,-Wmissing-braces]
> Dav1dPicture p = { 0 };
>
On 10/26/2018 7:50 PM, Dale Curtis wrote:
> One more piece of feedback, this is not obeying the
> AVCodecContext.get_buffer2 API.
It's not using it on purpose, wrapping the buffers dav1d allocated
itself instead. Hence the lack of AV_CODEC_CAP_DR1 flag.
>
> - dale
>
> On Fri, Oct 26, 2018 at 3:
One more piece of feedback, this is not obeying the
AVCodecContext.get_buffer2 API.
- dale
On Fri, Oct 26, 2018 at 3:31 PM Dale Curtis wrote:
> The following warnings show up when compiling with clang:
> ../../third_party/ffmpeg/libavcodec/libdav1d.c:92:24: error: suggest
> braces around initia
The following warnings show up when compiling with clang:
../../third_party/ffmpeg/libavcodec/libdav1d.c:92:24: error: suggest braces
around initialization of subobject [-Werror,-Wmissing-braces]
Dav1dPicture p = { 0 };
^
{}
../../third_party/ffmpeg
On Fri, Oct 26, 2018 at 10:46 PM Thierry Foucu wrote:
>
> On Wed, Oct 24, 2018 at 4:02 AM Rostislav Pehlivanov
> wrote:
>
> > On Sat, 20 Oct 2018 at 00:50, James Almer wrote:
> >
> > > Originally written by Ronald S. Bultje, with fixes, optimizations and
> > > improvements by James Almer.
> > >
Hey guys,
On Tue, Oct 23, 2018 at 4:42 PM James Almer wrote:
> On 10/23/2018 8:15 PM, Dale Curtis wrote:
> > On Fri, Oct 19, 2018 at 4:50 PM James Almer wrote:
> >
> >> +s.n_tile_threads = dav1d->tile_threads;
> >> +s.n_frame_threads = dav1d->frame_threads;
> >>
> >
> > Did you consider
On Wed, Oct 24, 2018 at 4:02 AM Rostislav Pehlivanov
wrote:
> On Sat, 20 Oct 2018 at 00:50, James Almer wrote:
>
> > Originally written by Ronald S. Bultje, with fixes, optimizations and
> > improvements by James Almer.
> >
> > Signed-off-by: James Almer
> > ---
> > Updated to work with libdav1
On Sat, 20 Oct 2018 at 00:50, James Almer wrote:
> Originally written by Ronald S. Bultje, with fixes, optimizations and
> improvements by James Almer.
>
> Signed-off-by: James Almer
> ---
> Updated to work with libdav1d git head.
>
> configure | 4 +
> libavcodec/Makefile|
On 10/23/2018 8:15 PM, Dale Curtis wrote:
> On Fri, Oct 19, 2018 at 4:50 PM James Almer wrote:
>
>> +s.n_tile_threads = dav1d->tile_threads;
>> +s.n_frame_threads = dav1d->frame_threads;
>>
>
> Did you consider using the AVCodecContext.threads value along
> AVCodecContext.thread_type fla
On Fri, Oct 19, 2018 at 4:50 PM James Almer wrote:
> +s.n_tile_threads = dav1d->tile_threads;
> +s.n_frame_threads = dav1d->frame_threads;
>
Did you consider using the AVCodecContext.threads value along
AVCodecContext.thread_type flags? That seems to be how this is handled
elsewhere.
-
Originally written by Ronald S. Bultje, with fixes, optimizations and
improvements by James Almer.
Signed-off-by: James Almer
---
Updated to work with libdav1d git head.
configure | 4 +
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/libdav1d.c | 271
13 matches
Mail list logo
