Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
Michael Niedermayer skrev: (27 februari 2016 01:30:52 CET) >On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: >> On 02/26/2016 05:26 AM, Mats Peterson wrote: >> >On 02/26/2016 05:08 AM, Mats Peterson wrote: >> >>Should hopefully fix the big-endian issue. >> >> >> > >> >Not that I und

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Michael Niedermayer
On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: > On 02/26/2016 05:26 AM, Mats Peterson wrote: > >On 02/26/2016 05:08 AM, Mats Peterson wrote: > >>Should hopefully fix the big-endian issue. > >> > > > >Not that I understand why. I thought the palette was already in > >"big-endian" or

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
On 02/26/2016 11:37 PM, Mats Peterson wrote: On 02/26/2016 11:36 PM, Mats Peterson wrote: i use qemu-mips myself mips is not fast, building on mips is really slow if one did that also cross building to mips should be the same speed as building to x86 would be qemu-mips would only run for a few

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
On 02/26/2016 11:36 PM, Mats Peterson wrote: i use qemu-mips myself mips is not fast, building on mips is really slow if one did that also cross building to mips should be the same speed as building to x86 would be qemu-mips would only run for a few seconds to do whatever you want to test. I ass

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
On 02/26/2016 11:31 PM, Michael Niedermayer wrote: On Fri, Feb 26, 2016 at 11:21:19PM +0100, Mats Peterson wrote: Michael Niedermayer skrev: (26 februari 2016 22:53:00 CET) On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: On 02/26/2016 05:26 AM, Mats Peterson wrote: On 02/26/2

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Michael Niedermayer
On Fri, Feb 26, 2016 at 11:21:19PM +0100, Mats Peterson wrote: > Michael Niedermayer skrev: (26 februari 2016 > 22:53:00 CET) > >On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: > >> On 02/26/2016 05:26 AM, Mats Peterson wrote: > >> >On 02/26/2016 05:08 AM, Mats Peterson wrote: > >>

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
Mats Peterson skrev: (26 februari 2016 23:21:19 CET) >Michael Niedermayer skrev: (26 februari 2016 >22:53:00 CET) >>On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: >>> On 02/26/2016 05:26 AM, Mats Peterson wrote: >>> >On 02/26/2016 05:08 AM, Mats Peterson wrote: >>> >>Should hopef

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
Michael Niedermayer skrev: (26 februari 2016 22:56:42 CET) >On Fri, Feb 26, 2016 at 08:00:58AM +0100, Mats Peterson wrote: >> On 02/26/2016 07:41 AM, Mats Peterson wrote: >> >>Look at this snippet from libavformat/qtpalette.c that stores a >palette >> >>entry (palette[] is uint32_t): >> >> >> >>p

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
Michael Niedermayer skrev: (26 februari 2016 22:53:00 CET) >On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: >> On 02/26/2016 05:26 AM, Mats Peterson wrote: >> >On 02/26/2016 05:08 AM, Mats Peterson wrote: >> >>Should hopefully fix the big-endian issue. >> >> >> > >> >Not that I und

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Michael Niedermayer
On Fri, Feb 26, 2016 at 08:00:58AM +0100, Mats Peterson wrote: > On 02/26/2016 07:41 AM, Mats Peterson wrote: > >>Look at this snippet from libavformat/qtpalette.c that stores a palette > >>entry (palette[] is uint32_t): > >> > >>palette[i] = (a << 24 ) | (r << 16) | (g << 8) | (b); > >> > >>The wa

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Michael Niedermayer
On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: > On 02/26/2016 05:26 AM, Mats Peterson wrote: > >On 02/26/2016 05:08 AM, Mats Peterson wrote: > >>Should hopefully fix the big-endian issue. > >> > > > >Not that I understand why. I thought the palette was already in > >"big-endian" or

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
On 02/26/2016 01:46 PM, Mats Peterson wrote: On 02/26/2016 01:16 PM, Mats Peterson wrote: On 02/26/2016 08:34 AM, Mats Peterson wrote: On 02/26/2016 08:28 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. __

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
On 02/26/2016 01:16 PM, Mats Peterson wrote: On 02/26/2016 08:34 AM, Mats Peterson wrote: On 02/26/2016 08:28 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-26 Thread Mats Peterson
On 02/26/2016 08:34 AM, Mats Peterson wrote: On 02/26/2016 08:28 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.or

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-25 Thread Mats Peterson
On 02/26/2016 08:28 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Forget this

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-25 Thread Mats Peterson
On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Forget this one as well. Using AV_RL32() shouldn't be nee

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-25 Thread Mats Peterson
On 02/26/2016 07:41 AM, Mats Peterson wrote: Look at this snippet from libavformat/qtpalette.c that stores a palette entry (palette[] is uint32_t): palette[i] = (a << 24 ) | (r << 16) | (g << 8) | (b); The way it is stored in memory is obviously dependent on the endianness of the machine. For l

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-25 Thread Mats Peterson
On 02/26/2016 06:40 AM, Mats Peterson wrote: On 02/26/2016 06:24 AM, Mats Peterson wrote: On 02/26/2016 05:26 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. Not that I understand why. I thought the palette was already in "big

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-25 Thread Mats Peterson
On 02/26/2016 06:24 AM, Mats Peterson wrote: On 02/26/2016 05:26 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. Not that I understand why. I thought the palette was already in "big-endian" order, with the A, R, G, B bytes in t

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-25 Thread Mats Peterson
On 02/26/2016 05:26 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. Not that I understand why. I thought the palette was already in "big-endian" order, with the A, R, G, B bytes in that order, and that the previous patch would r

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-25 Thread Mats Peterson
On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. Not that I understand why. I thought the palette was already in "big-endian" order, with the A, R, G, B bytes in that order, and that the previous patch would rather fail instead, so to say. But alright.

[FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

2016-02-25 Thread Mats Peterson
Should hopefully fix the big-endian issue. -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From 750f7e27518aa7cc9fb37240ba33a024deaead34 Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Fri, 26 Feb 2016 05:07:28 +0100 Subject: [PATCH v28] lavf/movenc: Add palette to video sample description