Re: [FFmpeg-devel] [PATCH v2 6/9] cbs_av1: Implement parser entrypoint

2019-04-02 Thread James Almer
On 4/1/2019 8:39 PM, Mark Thompson wrote: > +static int cbs_av1_parse_obu(CodedBitstreamContext *ctx, > + void *priv, int obu_type, > + const uint8_t *data, size_t data_size) > +{ > +CodedBitstreamUnit unit; > +int err; > + > +// T

Re: [FFmpeg-devel] [PATCH v2 6/9] cbs_av1: Implement parser entrypoint

2019-04-02 Thread James Almer
On 4/2/2019 3:36 PM, James Almer wrote: > On 4/1/2019 8:39 PM, Mark Thompson wrote: >> --- >> Unsure about this one - while the patch is short, it's rather invasive in a >> pretty ugly way with how it abuses the read call. It will still do >> allocations for the decomposition because of that, ev

Re: [FFmpeg-devel] [PATCH v2 6/9] cbs_av1: Implement parser entrypoint

2019-04-02 Thread James Almer
On 4/1/2019 8:39 PM, Mark Thompson wrote: > --- > Unsure about this one - while the patch is short, it's rather invasive in a > pretty ugly way with how it abuses the read call. It will still do > allocations for the decomposition because of that, even though we don't > really want them. > > A

[FFmpeg-devel] [PATCH v2 6/9] cbs_av1: Implement parser entrypoint

2019-04-01 Thread Mark Thompson
--- Unsure about this one - while the patch is short, it's rather invasive in a pretty ugly way with how it abuses the read call. It will still do allocations for the decomposition because of that, even though we don't really want them. Any ideas welcome. libavcodec/cbs_av1.c | 89 ++