Re: [FFmpeg-devel] [PATCH v2 3/8] avformat/utils: Preserve integrity of linked list

2019-09-18 Thread Michael Niedermayer
On Mon, Aug 19, 2019 at 11:56:19PM +0200, Andreas Rheinhardt wrote: > 1. Instead of relying on ff_packet_list_get to get the oldest element in > an AVPacketList, ff_read_packet used its own ad-hoc code. Said code > forgot to set the end of the list to NULL if the last element of the > list has been

[FFmpeg-devel] [PATCH v2 3/8] avformat/utils: Preserve integrity of linked list

2019-08-19 Thread Andreas Rheinhardt
1. Instead of relying on ff_packet_list_get to get the oldest element in an AVPacketList, ff_read_packet used its own ad-hoc code. Said code forgot to set the end of the list to NULL if the last element of the list has been removed, thereby leaving the list in an inconsistent state. 2. Furthermore,