Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-05-08 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年5月8日 下午7:07,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>> 2020年4月9日 下午8:58,Andreas Rheinhardt 写道: Steven Liu: > > >> 2020年4月9日 下午5:55,Steven Liu 写道: >> >> >> >>> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: >>> >>> Steve

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-05-08 Thread Steven Liu
> 2020年5月8日 下午7:07,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年4月9日 下午8:58,Andreas Rheinhardt 写道: >>> >>> Steven Liu: > 2020年4月9日 下午5:55,Steven Liu 写道: > > > >> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>>

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-05-08 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年4月9日 下午8:58,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>> 2020年4月9日 下午5:55,Steven Liu 写道: > 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: >>> >>> Signed-

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午8:58,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年4月9日 下午5:55,Steven Liu 写道: >>> >>> >>> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: Steven Liu: > > >> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: >> >> Signed-off-by: Andreas Rheinha

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年4月9日 下午5:55,Steven Liu 写道: >> >> >> >>> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: >>> >>> Steven Liu: > 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlsenc.c | 13 - > 1 fi

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Nicolas George
Limin Wang (12020-04-09): > Sorry, it seems that I remove these checking when av_dirname claims to support > NULL for path in the API comments like glib dirname function. So I think it's > duplicate check if the function claims to support NULL. "Supporting NULL" can mean anything, and therefore me

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Limin Wang
On Thu, Apr 09, 2020 at 11:48:10AM +0200, Andreas Rheinhardt wrote: > Steven Liu: > > > > > >> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavformat/hlsenc.c | 13 - > >> 1 file changed, 12 insertions(+), 1 deletion(-) > >> > >

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Nicolas George
Steven Liu (12020-04-09): > I said I don’t care about it here, because it don’t is not affected > the workflow, you can merge it if it can make you happy. I have no > reason objection it, and no reason agreed it.:D Ok. Also, please heed reply-to headers instead of Cc-ing anybody randomly. Regar

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午5:55,Steven Liu 写道: > > > >> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 13 - 1 file changed, 12 insertion

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: >>> >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> libavformat/hlsenc.c | 13 - >>> 1 file changed, 12 insertions(+), 1 deletion(-) >>> >>> diff --git a/libavformat/h

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/hlsenc.c | 13 - >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >> index a281c379f0..18f40ff3ed

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午5:33,Nicolas George 写道: > > Steven Liu (12020-04-09): >> I think every body have themselves reason to checking memory and remove the >> checking at here. >> Whatever for me you can add them here for somebody copy, other body remove >> them >> some days(maybe long time later) so

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Nicolas George
Steven Liu (12020-04-09): > I think every body have themselves reason to checking memory and remove the > checking at here. > Whatever for me you can add them here for somebody copy, other body remove > them > some days(maybe long time later) some body remove remove the for unnecessary > proces

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午4:49,Nicolas George 写道: > > Steven Liu (12020-04-09): >> It’s unnecessary here, >> I have checked all strdup return checker in hlsenc some month ago, and >> double check the workflow in update_master_pl_info, >> It's the safe whether you check the strdup or not. >> Reference comm

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Nicolas George
Steven Liu (12020-04-09): > It’s unnecessary here, > I have checked all strdup return checker in hlsenc some month ago, and double > check the workflow in update_master_pl_info, > It's the safe whether you check the strdup or not. > Reference commit id: 61aa77272a25d83e5ce5c63d93c64bb9a3e15557 Ho

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-08 Thread Steven Liu
> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlsenc.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index a281c379f0..18f40ff3ed 100644 > --- a/libavfo

[FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-02-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a281c379f0..18f40ff3ed 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1610,6 +1610,8 @@