Re: [FFmpeg-devel] [PATCH v2 3/4] mips: port optimizations to mips n64

2015-03-07 Thread James Cowgill
On Sat, 2015-03-07 at 10:15 +0100, Michael Niedermayer wrote: > On Sat, Mar 07, 2015 at 02:47:51AM -0300, James Almer wrote: > > On 05/03/15 2:40 PM, James Cowgill wrote: > > > diff --git a/libavutil/mips/asmdefs.h b/libavutil/mips/asmdefs.h > > > new file mode 100644 > > > index 000..4d2922c >

Re: [FFmpeg-devel] [PATCH v2 3/4] mips: port optimizations to mips n64

2015-03-07 Thread Michael Niedermayer
On Sat, Mar 07, 2015 at 02:47:51AM -0300, James Almer wrote: > On 05/03/15 2:40 PM, James Cowgill wrote: > > diff --git a/libavutil/mips/asmdefs.h b/libavutil/mips/asmdefs.h > > new file mode 100644 > > index 000..4d2922c > > --- /dev/null > > +++ b/libavutil/mips/asmdefs.h > > @@ -0,0 +1,48 @@

Re: [FFmpeg-devel] [PATCH v2 3/4] mips: port optimizations to mips n64

2015-03-06 Thread James Almer
On 05/03/15 2:40 PM, James Cowgill wrote: > diff --git a/libavutil/mips/asmdefs.h b/libavutil/mips/asmdefs.h > new file mode 100644 > index 000..4d2922c > --- /dev/null > +++ b/libavutil/mips/asmdefs.h > @@ -0,0 +1,48 @@ > +/* > + * Copyright (c) 2015 Imagination Technologies Ltd > + * > + * Th

Re: [FFmpeg-devel] [PATCH v2 3/4] mips: port optimizations to mips n64

2015-03-06 Thread Michael Niedermayer
On Fri, Mar 06, 2015 at 11:08:24AM +, Nedeljko Babic wrote: > LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfi

Re: [FFmpeg-devel] [PATCH v2 3/4] mips: port optimizations to mips n64

2015-03-06 Thread Nedeljko Babic
LGTM Thanks, - Nedeljko Od: James Cowgill [james...@cowgill.org.uk] Poslato: 5. mart 2015 18:40 Za: ffmpeg-devel@ffmpeg.org Cc: Nedeljko Babic; James Cowgill Tema: [PATCH v2 3/4] mips: port optimizations to mips n64 This mainly consists of replacing all th

[FFmpeg-devel] [PATCH v2 3/4] mips: port optimizations to mips n64

2015-03-05 Thread James Cowgill
This mainly consists of replacing all the pointer arithmatic 'addiu' instructions with PTR_ADDIU which will handle the differences in pointer sizes when compiled on 64 bit mips systems. The header asmdefs.h contains the PTR_ macros which expend to the correct mips instructions to manipulate regist