Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/dict: Add av_dict_iterate

2022-10-25 Thread Anton Khirnov
Quoting Marvin Scholz (2022-09-24 16:36:55) > diff --git a/libavutil/dict.h b/libavutil/dict.h > index 0d1afc6c64..344afb452b 100644 > --- a/libavutil/dict.h > +++ b/libavutil/dict.h > @@ -32,6 +32,8 @@ > > #include > > +#include "attributes.h" This seems unnecessary now. Will push with thi

Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/dict: Add av_dict_iterate

2022-10-11 Thread Marvin Scholz
On 24 Sep 2022, at 16:36, Marvin Scholz wrote: > This is a more explicit iteration API rather than using the "magic" > av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really > trivial to grasp what it does when casually reading through code. > --- > libavutil/dict.c| 19

[FFmpeg-devel] [PATCH v2 1/5] avutil/dict: Add av_dict_iterate

2022-09-24 Thread Marvin Scholz
This is a more explicit iteration API rather than using the "magic" av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really trivial to grasp what it does when casually reading through code. --- libavutil/dict.c| 19 +++ libavutil/dict.h| 46