Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata

2023-10-20 Thread Michael Niedermayer
On Fri, Oct 20, 2023 at 03:54:16PM +0200, Anton Khirnov wrote: > Quoting Niklas Haas (2023-10-14 13:46:34) > > > 3. I don't see how the MJPEG encoder behaviour where the valid formats > > > de facto depend upon strictness can be encoded in this way; isn't the > > > aim to get rid of the necessity o

Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata

2023-10-20 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-10-13 19:10:33) > Niklas Haas: > > From: Niklas Haas > > > > This is motivated primarily by a desire for YUVJ removal, which will > > require signalling the supported color ranges as part of the codec > > capabilities. But since we're here anyway, we might as well

Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata

2023-10-20 Thread Anton Khirnov
Quoting Niklas Haas (2023-10-14 13:46:34) > > 3. I don't see how the MJPEG encoder behaviour where the valid formats > > de facto depend upon strictness can be encoded in this way; isn't the > > aim to get rid of the necessity of the workaround in ffmpeg cli? > > Note that ffmpeg cli presently ini

Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata

2023-10-14 Thread Niklas Haas
On Sat, 14 Oct 2023 09:31:32 -0400 Leo Izen wrote: > On 10/13/23 10:24, Niklas Haas wrote: > > From: Niklas Haas > > > > This is motivated primarily by a desire for YUVJ removal, which will > > require signalling the supported color ranges as part of the codec > > capabilities. But since we're h

Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata

2023-10-14 Thread Niklas Haas
On Fri, 13 Oct 2023 19:10:33 +0200 Andreas Rheinhardt wrote: > 2. It is based around the underlying assumption that the set of > permissible states (tupels) is a cartesian product of a set of color > spaces, a set of color ranges etc. This is wrong: E.g. VP9 disallows > limited-range RGB (it is s

Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata

2023-10-14 Thread Niklas Haas
On Fri, 13 Oct 2023 19:10:33 +0200 Andreas Rheinhardt wrote: > This design has several drawbacks: > 1. It adds stuff that will only be set by a tiny minority of AVCodec's > to all of them. > 2. It is based around the underlying assumption that the set of > permissible states (tupels) is a cartesi

Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata

2023-10-13 Thread Vittorio Giovara
On Fri, Oct 13, 2023 at 1:09 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > 2. It is based around the underlying assumption that the set of > permissible states (tupels) is a cartesian product of a set of color > spaces, a set of color ranges etc. This is wrong: E.g. VP9 disallow

[FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata

2023-10-13 Thread Niklas Haas
From: Niklas Haas This is motivated primarily by a desire for YUVJ removal, which will require signalling the supported color ranges as part of the codec capabilities. But since we're here anyway, we might as well add all of the metadata, which I foresee seeing more use in the future (e.g. automa