Re: [FFmpeg-devel] [PATCH v2] mov: Remove duration-of-last-frame heuristic hack

2019-01-02 Thread Derek Buitenhuis
On 01/01/2019 15:50, Derek Buitenhuis wrote: > If there are no objections, I will push in a day or two. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] mov: Remove duration-of-last-frame heuristic hack

2019-01-01 Thread Derek Buitenhuis
On 24/12/2018 19:55, Derek Buitenhuis wrote: > --- > v1 had accidentally removed a cast. Woops. > libavformat/mov.c | 6 -- > 1 file changed, 6 deletions(-) If there are no objections, I will push in a day or two. - Derek ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH v2] mov: Remove duration-of-last-frame heuristic hack

2018-12-29 Thread Derek Buitenhuis
On 29/12/2018 10:36, Carl Eugen Hoyos wrote: > Please provide a sample. I mean, the hack being removing is *obviously* wrong and against the QTFF and ISOBMFF specs, to ignore values based on a heuristic. However, since you insist: http://chromashift.org/ffmpegsamps/valid_file.mp4 - Derek ___

Re: [FFmpeg-devel] [PATCH v2] mov: Remove duration-of-last-frame heuristic hack

2018-12-29 Thread Carl Eugen Hoyos
2018-12-28 17:07 GMT+01:00, Derek Buitenhuis : > On 24/12/2018 19:55, Derek Buitenhuis wrote: >> This breaks totally valid files that get caught in its heuristic. >> >> This, according to the commit message, is my own doing, having asked >> Michael to implement this check and providing a sample tha

Re: [FFmpeg-devel] [PATCH v2] mov: Remove duration-of-last-frame heuristic hack

2018-12-28 Thread Derek Buitenhuis
On 24/12/2018 19:55, Derek Buitenhuis wrote: > This breaks totally valid files that get caught in its heuristic. > > This, according to the commit message, is my own doing, having asked > Michael to implement this check and providing a sample that was > "wrong". I am now atoning for my sins, and r

[FFmpeg-devel] [PATCH v2] mov: Remove duration-of-last-frame heuristic hack

2018-12-24 Thread Derek Buitenhuis
This breaks totally valid files that get caught in its heuristic. This, according to the commit message, is my own doing, having asked Michael to implement this check and providing a sample that was "wrong". I am now atoning for my sins, and removing this hack, having seen the light (aka that this