Re: [FFmpeg-devel] [PATCH v2] libavformat: add RCWT closed caption muxer

2024-01-07 Thread Stefano Sabatini
On date Saturday 2024-01-06 15:41:05 -0600, Marth64 wrote: > Signed-off-by: Marth64 > > Thank you for the good feedback and review. Most feedback is addressed. > > > nit: no need to shift > I left this alone only since I see it being done this way in lavf/ccfifo > and other documentation. I ass

[FFmpeg-devel] [PATCH v2] libavformat: add RCWT closed caption muxer

2024-01-06 Thread Marth64
Signed-off-by: Marth64 Thank you for the good feedback and review. Most feedback is addressed. > nit: no need to shift I left this alone only since I see it being done this way in lavf/ccfifo and other documentation. I assumed it could be doing the shift for a reason, but I can study further wh