Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 12:21:01 +0200 Nicolas George wrote: > Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > > Both ffmpeg.c and the API are very complex, so it's obvious that > > ffmpeg.c can't possibly be using all possible ways the API can be used. > > FUD again. > > > If you really want a

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > Both ffmpeg.c and the API are very complex, so it's obvious that > ffmpeg.c can't possibly be using all possible ways the API can be used. FUD again. > If you really want a concrete example: av_seek_frame() is not used in > any of the command li

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 12:01:51 +0200 Nicolas George wrote: > Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > > How hard is it to understand that a program built for a specific > > purpose can not be made to use an API in all possible ways? Unless you > > add dozens of redundant code paths to ff

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > How hard is it to understand that a program built for a specific > purpose can not be made to use an API in all possible ways? Unless you > add dozens of redundant code paths to ffmpeg.c (do you want this?), you > won't be able to get full API cov

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 11:34:28 +0200 Nicolas George wrote: > Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > > [ I skip over the usual jealousy rants. ] > > > Your attitude also shows an amazing chauvinism: who cares about the API > > users (and any downstream projects), as long as the comman

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : [ I skip over the usual jealousy rants. ] > Your attitude also shows an amazing chauvinism: who cares about the API > users (and any downstream projects), as long as the command line tools > are fine? And you fail to understand. Once again. The

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 11:07:16 +0200 Nicolas George wrote: > Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > > Because we want to test the API, not the command line tools. > > And the command line tools, as everybody knows, operate by magic instead of > using the API. The command line tools a

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le sextidi 26 germinal, an CCXXIII, wm4 a écrit : > Because we want to test the API, not the command line tools. And the command line tools, as everybody knows, operate by magic instead of using the API. If there is a point of the API that can not be accessed with the command-line tools, fix that

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 09:23:04 +0200 Nicolas George wrote: > But for this particular case, I wonder why there is so much code for a > specific codec test while all other codecs are tested using the standard > command-line tools. Because we want to test the API, not the command line tools.

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread wm4
On Tue, 14 Apr 2015 23:08:02 + Ludmila Glinskih wrote: > > > +{ > > > +if (result != enc_pkt.size) > > > +{ > > > +av_log(NULL, AV_LOG_INFO, "Decoder consumed only > > part of a packet, it is allowed to do so -- need to update th

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-15 Thread Nicolas George
Le quintidi 25 germinal, an CCXXIII, Michael Niedermayer a écrit : > please avoid float/double > see tests/audiogen.c as an example or maybe better use tests/audiogen > so no code is duplicated Just for the record, there is also asrc_sine.c in lavfi that generates a bit-exact sine signal. I have

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-14 Thread Ludmila Glinskih
Hi, Thanks for you comments! > +static int generate_raw_frame(uint16_t *frame_data, int i, int > sample_rate, > > + int channels, int frame_size) > > +{ > > +double t, tincr, tincr2; > > +int j, k; > > + > > +t = 0.0; > > +tincr = 2 * M_PI * 440.0 / sa

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-14 Thread wm4
On Tue, 14 Apr 2015 04:03:40 +0300 Ludmila Glinskih wrote: > This is a simple test for the FLAC codec. > It generates an increasing tone, encodes it, decodes it back and > compares with the original one byte-by-byte. > --- > configure| 2 + > doc/Makefile | 1 + >

Re: [FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-14 Thread Michael Niedermayer
On Tue, Apr 14, 2015 at 04:03:40AM +0300, Ludmila Glinskih wrote: > This is a simple test for the FLAC codec. > It generates an increasing tone, encodes it, decodes it back and > compares with the original one byte-by-byte. > --- > configure| 2 + > doc/Makefile | 1

[FFmpeg-devel] [PATCH v2] examples: add flac_test

2015-04-13 Thread Ludmila Glinskih
This is a simple test for the FLAC codec. It generates an increasing tone, encodes it, decodes it back and compares with the original one byte-by-byte. --- configure| 2 + doc/Makefile | 1 + doc/examples/Makefile| 1 + doc/examples/flac_test.c | 295 +