Re: [FFmpeg-devel] [PATCH v2] avdevice/xcbgrab: Add select_region option.

2020-07-01 Thread Omar Emara
Hi Andriy, > > > +#include > > this include is not used > The string.h include is needed by the strlen function. Is it not? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit li

Re: [FFmpeg-devel] [PATCH v2] avdevice/xcbgrab: Add select_region option.

2020-06-30 Thread Andriy Gelman
Hi Omar, Thanks for your patch. nit: please remove "." at the end of the commit title On Sun, 28. Jun 13:26, Omar Emara wrote: > This patch adds a select_region option to the xcbgrab input device. > If set to 1, the user will be prompted to select the grabbing area > graphically by clicking and

[FFmpeg-devel] [PATCH v2] avdevice/xcbgrab: Add select_region option.

2020-06-28 Thread Omar Emara
This patch adds a select_region option to the xcbgrab input device. If set to 1, the user will be prompted to select the grabbing area graphically by clicking and dragging. A rectangle will be drawn to mark the grabbing area. A single click with no dragging will select the whole screen. The option