Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread James Almer
On 10/3/2018 8:26 PM, Mark Thompson wrote: > On 03/10/18 02:44, James Almer wrote: >> Simple parser to set keyframes, frame type, structure, width, height, and >> pixel >> format, plus stream profile and level. >> >> Signed-off-by: James Almer >> --- >> Missing Changelog entry and version bump st

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Mark Thompson
On 03/10/18 02:44, James Almer wrote: > Simple parser to set keyframes, frame type, structure, width, height, and > pixel > format, plus stream profile and level. > > Signed-off-by: James Almer > --- > Missing Changelog entry and version bump still. > > configure | 1 + > libav

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Derek Buitenhuis
On 03/10/2018 14:43, James Almer wrote: > That's in Metadata OBUs and/or in container defined structures. It's > meant to be propagated internally as stream/packet/frame side data, > which the parser API can't handle. > > The demuxer and/or the decoder are the ones that need to handle that. OK.

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread James Almer
On 10/3/2018 10:38 AM, Derek Buitenhuis wrote: > On 03/10/2018 14:26, James Almer wrote: >>> Shouldn't this be set at the bottom of this block (since parsing can fail)? >> >> If extradata parsing fails and we bail out without setting this first, >> no packet will ever be parsed since this runs firs

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Derek Buitenhuis
On 03/10/2018 14:26, James Almer wrote: >> Shouldn't this be set at the bottom of this block (since parsing can fail)? > > If extradata parsing fails and we bail out without setting this first, > no packet will ever be parsed since this runs first thing every time. > > A better API would allow us

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread James Almer
On 10/3/2018 9:53 AM, Derek Buitenhuis wrote: > Hi, > > Apologies if you've covered any of these comments before. > > On 03/10/2018 02:44, James Almer wrote: >> Simple parser to set keyframes, frame type, structure, width, height, and >> pixel >> format, plus stream profile and level. >> >> Sign

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Derek Buitenhuis
On 03/10/2018 13:53, Derek Buitenhuis wrote: > Won't this break horribly on e.g. 4:4:0? Woops, there's no such thing in AV1. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-03 Thread Derek Buitenhuis
Hi, Apologies if you've covered any of these comments before. On 03/10/2018 02:44, James Almer wrote: > Simple parser to set keyframes, frame type, structure, width, height, and > pixel > format, plus stream profile and level. > > Signed-off-by: James Almer > --- > Missing Changelog entry and

[FFmpeg-devel] [PATCH v2] avcodec: add an AV1 parser

2018-10-02 Thread James Almer
Simple parser to set keyframes, frame type, structure, width, height, and pixel format, plus stream profile and level. Signed-off-by: James Almer --- Missing Changelog entry and version bump still. configure | 1 + libavcodec/Makefile | 1 + libavcodec/av1_parser.c | 226 +