On 07/25/2016 05:14 PM, Nicolas George wrote:
Le septidi 7 thermidor, an CCXXIV, Jan Sebechlebsky a écrit :
I gave this a second thought, wouldn't it be better to simply ignore pkt
without payload? So after caller would send empty packet using
av_bsf_send_packet, he would get AVERROR(EAGAIN) fr
Le septidi 7 thermidor, an CCXXIV, Jan Sebechlebsky a écrit :
> I gave this a second thought, wouldn't it be better to simply ignore pkt
> without payload? So after caller would send empty packet using
> av_bsf_send_packet, he would get AVERROR(EAGAIN) from the next
> av_bsf_receive_packet call (fr
On 07/22/2016 10:14 PM, Nicolas George wrote:
Le quintidi 5 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit :
From: Jan Sebechlebsky
Set BSF EOF flag only if pkt == NULL in av_bsf_send_packet().
Signed-off-by: Jan Sebechlebsky
---
I agree, it seems cleaner that way.
Thanks,
On Fri, Jul 22, 2016 at 10:14:16PM +0200, Nicolas George wrote:
> Le quintidi 5 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit :
> > From: Jan Sebechlebsky
[...]
> and an assert failure is the most sympathetic undefined
> behaviours for developers.
+1
[...]
--
Michael GnuPG finge
Le quintidi 5 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit :
> From: Jan Sebechlebsky
>
> Set BSF EOF flag only if pkt == NULL in av_bsf_send_packet().
>
> Signed-off-by: Jan Sebechlebsky
> ---
> I agree, it seems cleaner that way.
>
> Thanks,
> please apply this version of patch
From: Jan Sebechlebsky
Set BSF EOF flag only if pkt == NULL in av_bsf_send_packet().
Signed-off-by: Jan Sebechlebsky
---
I agree, it seems cleaner that way.
Thanks,
please apply this version of patch then and ignore
the patch changing the comment.
Regards,
Jan
libavcodec/bsf.c | 2 +-
