Re: [FFmpeg-devel] [PATCH v2] Add 2 timestamp print formats

2019-07-19 Thread Ulf Zibis
Am 03.07.19 um 10:52 schrieb Michael Niedermayer: > >> I too thought on that, but the existing functions too rely on >> float/double. Should I anyway provide a solution with integer arithmetic? > its indepedant of your patch but i think all these should use integers > unless its too messy Now see

Re: [FFmpeg-devel] [PATCH v2] Add 2 timestamp print formats

2019-07-03 Thread Michael Niedermayer
On Tue, Jul 02, 2019 at 12:28:53AM +0200, Ulf Zibis wrote: > Thanks Michael for your review, answers inline ... > > Am 01.07.19 um 17:16 schrieb Michael Niedermayer: > >> timestamp.h | 78 > >> > >> 1 file changed, 73 insertions(+),

Re: [FFmpeg-devel] [PATCH v2] Add 2 timestamp print formats

2019-07-01 Thread Ulf Zibis
Am 02.07.19 um 00:28 schrieb Ulf Zibis: >> If this could be done without float/double that would be preferred as it >> avoids inaccuracies / slight differences between platforms > I too thought on that, but the existing functions too rely on > float/double. Should I anyway provide a solution with

Re: [FFmpeg-devel] [PATCH v2] Add 2 timestamp print formats

2019-07-01 Thread Ulf Zibis
Thanks Michael for your review, answers inline ... Am 01.07.19 um 17:16 schrieb Michael Niedermayer: >> timestamp.h | 78 >> >> 1 file changed, 73 insertions(+), 5 deletions(-) >> 3d1275421b1b8d4952815151158c7af954d38ca6 timestamp_2

Re: [FFmpeg-devel] [PATCH v2] Add 2 timestamp print formats

2019-07-01 Thread Michael Niedermayer
On Mon, Jul 01, 2019 at 11:51:30AM +0200, Ulf Zibis wrote: > > Am 29.06.19 um 18:12 schrieb Ulf Zibis: > > Hi, > > > > for my developement of another filter I need additional timestamp print > > formats. > > > > So I like to share my efforts. Are you interested to include them to the > > project?

Re: [FFmpeg-devel] [PATCH v2] Add 2 timestamp print formats

2019-07-01 Thread Ulf Zibis
Am 29.06.19 um 18:12 schrieb Ulf Zibis: > Hi, > > for my developement of another filter I need additional timestamp print > formats. > > So I like to share my efforts. Are you interested to include them to the > project? > > For libavutil/timestamp.h I'm also wondering, why these format functions