Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Saturday, November 27, 2021 11:33 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for > subtitle handling

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-11-27 10:42:31) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2021-11-27 10:06:35) > >> Anton Khirnov: > >>> > >>> Not sure whether this was asked already - why do we need this new > >>> function? Seems to me you can accomplish the same thing by just adding > >>>

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2021-11-27 10:06:35) >> Anton Khirnov: >>> >>> Not sure whether this was asked already - why do we need this new >>> function? Seems to me you can accomplish the same thing by just adding >>> the type field to AVFrame. Then >>> - if type is AVMEDIA_TYPE_

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Saturday, November 27, 2021 10:25 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for > subtitle handling

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Saturday, November 27, 2021 10:01 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for > subtitle handling &g

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-11-27 10:06:35) > Anton Khirnov: > > > > Not sure whether this was asked already - why do we need this new > > function? Seems to me you can accomplish the same thing by just adding > > the type field to AVFrame. Then > > - if type is AVMEDIA_TYPE_SUBTITLE -> alloc

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Saturday, November 27, 2021 9:52 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for > subtitle handling > > Quoting Soft

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Soft Works (2021-11-25 18:53:24) >> @@ -759,9 +802,39 @@ void av_frame_move_ref(AVFrame *dst, AVFrame *src); >> * recommended to pass 0 here unless you know what you are >> doing. >> * >> * @return 0 on success, a negative AVERROR on error. >> + * >> + *

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Anton Khirnov
Quoting Soft Works (2021-11-26 19:25:17) > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Anton > > Khirnov > > Sent: Friday, November 26, 2021 5:21 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PA

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Anton Khirnov
Quoting Soft Works (2021-11-25 18:53:24) > @@ -759,9 +802,39 @@ void av_frame_move_ref(AVFrame *dst, AVFrame *src); > * recommended to pass 0 here unless you know what you are > doing. > * > * @return 0 on success, a negative AVERROR on error. > + * > + * @deprecated Use @ref av

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Friday, November 26, 2021 11:35 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFram

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-26 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Friday, November 26, 2021 11:35 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for > subtitle handling Hi Andreas, th

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-26 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Friday, November 26, 2021 5:21 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for > subtitle handling > > You hav

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-26 Thread Anton Khirnov
You have completely disregarded my comments on the previous patch. Stop doing that, it is rude. Your patchset is unacceptable until you deal with them. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-26 Thread Andreas Rheinhardt
Soft Works: > Root commit for adding subtitle filtering capabilities. > In detail: > > - Add type (AVMediaType) field to AVFrame > Replaces previous way of distinction which was based on checking > width and height to determine whether a frame is audio or video > - Add subtitle fields to AVFra

[FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct AVSubt