Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2022-01-07 Thread Pierre-Anthony Lemieux
On Fri, Jan 7, 2022 at 12:15 AM Paul B Mahol wrote: > > On Fri, Dec 31, 2021 at 2:25 PM Zane van Iperen > wrote: > > > > > > > On 31/12/21 21:19, Paul B Mahol wrote: > > > ++i instead of i++ > > > > > > > You're right, I missed that. I'll submit a patch. > > > > Still not posted/fixed. > > This w

Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2022-01-07 Thread Paul B Mahol
On Fri, Dec 31, 2021 at 2:25 PM Zane van Iperen wrote: > > > On 31/12/21 21:19, Paul B Mahol wrote: > > ++i instead of i++ > > > > You're right, I missed that. I'll submit a patch. > Still not posted/fixed. This whole sorry situation makes me very sad. _

Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2021-12-31 Thread Lynne
31 Dec 2021, 14:25 by z...@zanevaniperen.com: > > > On 31/12/21 21:19, Paul B Mahol wrote: > >> ++i instead of i++ >> > > You're right, I missed that. I'll submit a patch. > Revert it today or I will. I NAK'd it from entering 5.0. It requires more fuzzing, more testing and more reviewing. As for

Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2021-12-31 Thread Zane van Iperen
On 31/12/21 21:19, Paul B Mahol wrote: ++i instead of i++ You're right, I missed that. I'll submit a patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, o

Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2021-12-31 Thread Paul B Mahol
++i instead of i++ On Fri, Dec 31, 2021 at 11:40 AM Zane van Iperen wrote: > > > On 31/12/21 19:40, Paul B Mahol wrote: > > Why was this applied? > > >> > >> Both patches lgtm, I'll apply in a few days if no objections. > >> > > No one objected. > > > > It still breaks style of ffmpeg code, just

Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2021-12-31 Thread Zane van Iperen
On 31/12/21 19:40, Paul B Mahol wrote: Why was this applied? Both patches lgtm, I'll apply in a few days if no objections. No one objected. It still breaks style of ffmpeg code, just from quick glance. Which parts specifically? The main potential issue I can see is the long scanf(

Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2021-12-31 Thread Paul B Mahol
Why was this applied? It still breaks style of ffmpeg code, just from quick glance. Please revert or I leave this project forever. On Tue, Dec 28, 2021 at 6:28 AM Zane van Iperen wrote: > > > On 27/12/21 10:47, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2021-12-27 Thread Zane van Iperen
On 27/12/21 10:47, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: The IMF demuxer accepts as input an IMF CPL. The assets referenced by the CPL can be contained in multiple deliveries, each defined by an ASSETMAP file:

[FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

2021-12-26 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: The IMF demuxer accepts as input an IMF CPL. The assets referenced by the CPL can be contained in multiple deliveries, each defined by an ASSETMAP file: ffmpeg -assetmaps ,,... -i If -asset